Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #134

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Update README.md #134

merged 2 commits into from
Feb 7, 2024

Conversation

pemulis
Copy link
Contributor

@pemulis pemulis commented Aug 30, 2023

Improvements to the description of the oSnap module.

New PR guide

Please choose one of the below templates for your PR, feel free to delete any redundant information.

Add a feature

Feature Request

Link to any corresponding issue(s) describing the feature request(s).

Implementation

A concise description of the implementation(s).

Additional Context

Add any other context about the implementation(s) here.


Fix a bug

Bug Report

Link to any corresponding issue(s) describing the bug(s).

Implementation

A concise description of the implemented solution(s) to the reported bug(s).

Additional Context

Add any other context about the implementation here.


Add a module to this repo

Title

What is your module called?

Description

A brief description of what your module does.

Audit

Link to an audit of your module's code, performed be a reputable auditor.

Checklist

Prior to being merged, this PR must meet the following requirements.

This PR:

  • Adds details of the module to the README (items are sorted alphabetically)
  • Adds addresses of the canonical deployments of the mastercopy for your module to deployments.json, along with addresses and ABI details to constants.ts. Ideally these should be deterministic deployments that can be easily replicated on other supported networks.
  • Includes an audit from a reputable auditor.

Improvements to the description of the oSnap module
@github-actions
Copy link

github-actions bot commented Aug 30, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auryn-macmillan
Copy link
Member

@pemulis, could you please post the following to satisfy the cla assistant

I have read the CLA Document and I hereby sign the CLA

@pemulis
Copy link
Contributor Author

pemulis commented Nov 24, 2023

I have read the CLA Document and I hereby sign the CLA

auryn-macmillan
auryn-macmillan previously approved these changes Feb 7, 2024
@auryn-macmillan auryn-macmillan merged commit a12f2c3 into gnosisguild:master Feb 7, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants