Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [GSW-1956] claim all button visibility #567

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix [GSW-1956] claim all button visibility #567

merged 1 commit into from
Nov 20, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Nov 20, 2024

Purpose

  • Fixes a UI bug in the Claimable Rewards section of the Governance page where the Claim All button is not exposed even though a quantity exists.

Description

  • In the Governance > Claimable Rewards section, the Claim All button does not display even though there is a quantity of tokens available to claim
  • Users are blocked from claiming their rewards

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:08am

@tfrg tfrg force-pushed the GSW-1956-claim-all-button-visibility branch from 90c4825 to 3432bc8 Compare November 20, 2024 09:34
@tfrg tfrg force-pushed the GSW-1956-claim-all-button-visibility branch from 3432bc8 to 8e0faf0 Compare November 20, 2024 10:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tfrg tfrg merged commit fdb2e4d into develop Nov 20, 2024
6 checks passed
@tfrg tfrg deleted the GSW-1956-claim-all-button-visibility branch November 20, 2024 10:14
This was referenced Nov 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

@r3v4s r3v4s Awaiting requested review from r3v4s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfrg @notJoon @onlyhyde @jinoosss