Shrink binary size & speed-up build by replacing heavy DNS SDKs (Phase 1) #2527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* alidns * yandex cloud * tencentdns * sakuracloud * huaweicloud * cloudflare * oraclecloud
Member
|
This is not something we want to do. Using official clients is a way to ease the maintenance. Before doing this type of PR, it's better to open an issue to ask what the project wants. Also, your PR contains a wrong rebase, a lot of lint issues, design issues, and unrelated changes. |
Member
|
@0xJacky For your information, I asked DNS providers if they could improve their library size, and some of them did it, so I updated the modules:
*: This is the way we build the official binaries, and I recommend using it. ( Some other DNS providers will improve their API client size, so this will continue to be improved in the future. |
Author
|
Thanks for your hard works! This seems to be a better solution. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Background
lego(commit e9a255d) embedded several full-blown cloud SDKs just to talk to their DNS APIs.On macOS (MacBook Pro M2 Pro) this produced:
The bottleneck was a handful of vendored SDKs that together weighed ~48 MB of source code:
Why simplification is feasible:
The popular ACME client acme.sh performs the same DNS-01 operations with nothing more than shell +
curlcalls, proving that a lightweight approach is both practical and battle-tested.2. What this PR does
Re-implements seven DNS providers using either
Removes all the SDKs listed above from
go.mod.Phase 1 providers fully migrated & tested (both unit tests and live tests):
alidnsyandex(Yandex Cloud)tencentdnssakuracloudhuaweicloudcloudflareoraclecloud3. Impact
go.sum, fastergo mod download.4. Future work
aws-sdk-go. Plan to replace them with hand-rolled API calls.5. Checklist