Skip to content

Commit

Permalink
Enhance stylelint rule config, remove dead CSS (#24472)
Browse files Browse the repository at this point in the history
Make this stylelint rule match on more properties.

The dead CSS relates to the navbar, which currently has classes:

```
ui top secondary stackable main menu following bar light
```

Which means `.following.bar .top.menu` can never match, so remove this
dead CSS as well as inactive `z-index` and `left` on it.

Commits table striping becomes more visible on dark theme, but I don't
think it's worth introducing a new color until
#24423 is ready, which would have
to remove it again:

<img width="668" alt="Screenshot 2023-05-01 at 18 41 49"
src="https://user-images.githubusercontent.com/115237/235489873-6b272899-1d78-443a-872c-ee7731c269f9.png">
<img width="680" alt="Screenshot 2023-05-01 at 18 41 41"
src="https://user-images.githubusercontent.com/115237/235489878-1b9468af-c74f-48a6-a469-9eba57cfcb4d.png">
  • Loading branch information
silverwind committed May 3, 2023
1 parent 3362620 commit 3ae9976
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .stylelintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ rules:
property-no-vendor-prefix: null
rule-empty-line-before: null
rule-selector-property-disallowed-list: null
scale-unlimited/declaration-strict-value: [color, {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor)$/}]
scale-unlimited/declaration-strict-value: [[color, background-color, border-color], {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor|none)$/, ignoreFunctions: false}]
selector-attribute-name-disallowed-list: null
selector-attribute-operator-allowed-list: null
selector-attribute-operator-disallowed-list: null
Expand Down
20 changes: 0 additions & 20 deletions web_src/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -1228,8 +1228,6 @@ img.ui.avatar,
}

.following.bar {
z-index: 900;
left: 0;
margin: 0 !important;
}

Expand All @@ -1242,24 +1240,6 @@ img.ui.avatar,
margin-top: 0;
}

.following.bar .top.menu a.item.brand {
padding-left: 0;
}

.following.bar .top.menu a.item:hover,
.following.bar .top.menu .dropdown.item:hover,
.following.bar .top.menu .dropdown.item.active {
background-color: transparent;
}

.following.bar .top.menu a.item:hover {
color: rgba(0, 0, 0, 0.45);
}

.following.bar .top.menu .menu {
z-index: 900;
}

.following.bar .fitted .svg {
margin-right: 0;
vertical-align: middle;
Expand Down
2 changes: 1 addition & 1 deletion web_src/css/repository.css
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@
}

.repository #commits-table.ui.basic.striped.table tbody tr:nth-child(2n) {
background-color: rgba(0, 0, 0, 0.02) !important;
background-color: var(--color-light) !important;
}

.repository #commits-table td.sha .sha.label,
Expand Down

0 comments on commit 3ae9976

Please sign in to comment.