Fix a bug missed return (#35655) (#35667)

GiteaBot · lunny · web-flow · commit 5ae9bb4df9af · 2025-10-15T07:40:31.000+02:00
Backport #35655 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
diff --git a/routers/web/auth/oauth2_provider.go b/routers/web/auth/oauth2_provider.go
@@ -636,6 +636,7 @@ func handleAuthorizationCode(ctx *context.Context, form forms.AccessTokenForm, s
 			ErrorCode:        oauth2_provider.AccessTokenErrorCodeInvalidRequest,
 			ErrorDescription: "cannot proceed your request",
 		})
+		return
 	}
 	resp, tokenErr := oauth2_provider.NewAccessTokenResponse(ctx, authorizationCode.Grant, serverKey, clientKey)
 	if tokenErr != nil {

Original file line number	Diff line number	Diff line change
`@@ -636,6 +636,7 @@ func handleAuthorizationCode(ctx *context.Context, form forms.AccessTokenForm, s`
`636`	`636`	`ErrorCode: oauth2_provider.AccessTokenErrorCodeInvalidRequest,`
`637`	`637`	`ErrorDescription: "cannot proceed your request",`
`638`	`638`	`})`
	`639`	`+ return`
`639`	`640`	`}`
`640`	`641`	`resp, tokenErr := oauth2_provider.NewAccessTokenResponse(ctx, authorizationCode.Grant, serverKey, clientKey)`
`641`	`642`	`if tokenErr != nil {`