lint & fix test

Author: Zettat123

models/fixtures/action_run.yml

@@ -142,14 +142,15 @@
 -
   id: 804
   title: "use a private action"
-  repo_id: 6
-  owner_id: 10
+  repo_id: 60
+  owner_id: 40
   workflow_id: "run.yaml"
   index: 189
-  trigger_user_id: 10
+  trigger_user_id: 40
   ref: "refs/heads/master"
   commit_sha: "6e64b26de7ba966d01d90ecfaf5c7f14ef203e86"
   event: "push"
+  trigger_event: "push"
   is_fork_pull_request: 0
   status: 1
   started: 1683636528

routers/web/repo/setting/actions.go

@@ -5,7 +5,6 @@ package setting
 
 import (
 	"errors"
-	"fmt"
 	"net/http"
 	"strings"
 
@@ -43,7 +42,7 @@ func ActionsGeneralSettings(ctx *context.Context) {
 }
 
 func AddCollaborativeOwner(ctx *context.Context) {
-	redirectURL := fmt.Sprintf("%s/settings/actions/general", ctx.Repo.RepoLink)
+	redirectURL := ctx.Repo.RepoLink + "/settings/actions/general"
 	name := strings.ToLower(ctx.FormString("collaborative_owner"))
 
 	ownerID, err := user_model.GetUserOrOrgIDByName(ctx, name)
@@ -73,7 +72,7 @@ func AddCollaborativeOwner(ctx *context.Context) {
 }
 
 func DeleteCollaborativeOwner(ctx *context.Context) {
-	redirectURL := fmt.Sprintf("%s/settings/actions/general", ctx.Repo.RepoLink)
+	redirectURL := ctx.Repo.RepoLink + "/settings/actions/general"
 	ownerID := ctx.FormInt64("id")
 
 	actionsUnit, err := ctx.Repo.Repository.GetUnit(ctx, unit_model.TypeActions)

tests/integration/actions_settings_test.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
+	"strconv"
 	"testing"
 
 	repo_model "code.gitea.io/gitea/models/repo"
@@ -49,12 +50,12 @@ func TestActionsCollaborativeOwner(t *testing.T) {
 		// remove user10 from the list of collaborative owners
 		req = NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/settings/actions/general/collaborative_owner/delete", actionRepo.OwnerName, actionRepo.Name), map[string]string{
 			"_csrf": user2CSRF,
-			"id":    fmt.Sprintf("%d", user10.ID),
+			"id":    strconv.FormatInt(user10.ID, 10),
 		})
 		resp := user2Session.MakeRequest(t, req, http.StatusOK)
 		res := make(map[string]string)
 		assert.NoError(t, json.NewDecoder(resp.Body).Decode(&res))
-		assert.EqualValues(t, fmt.Sprintf("/%s/%s/settings/actions/general", actionRepo.OwnerName, actionRepo.Name), res["redirect"])
+		assert.Equal(t, fmt.Sprintf("/%s/%s/settings/actions/general", actionRepo.OwnerName, actionRepo.Name), res["redirect"])
 
 		// the git clone will fail
 		doGitCloneFail(u)(t)