add tests

go-gitea · Mar 5, 2024 · c31988e · c31988e
1 parent 4484c69
commit c31988e
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/models/repo/repo.go b/models/repo/repo.go
@@ -286,6 +286,9 @@ func (repo *Repository) AfterLoad() {
  repo.NumOpenMilestones = repo.NumMilestones - repo.NumClosedMilestones
  repo.NumOpenProjects = repo.NumProjects - repo.NumClosedProjects
  repo.NumOpenActionRuns = repo.NumActionRuns - repo.NumClosedActionRuns
+ if repo.DefaultWikiBranch == "" {
+ repo.DefaultWikiBranch = setting.Repository.DefaultBranch
+ }
 }
 
 // LoadAttributes loads attributes of the repository.

diff --git a/routers/web/repo/wiki_test.go b/routers/web/repo/wiki_test.go
@@ -9,6 +9,7 @@ import (
  "net/url"
  "testing"
 
+ "code.gitea.io/gitea/models/db"
  repo_model "code.gitea.io/gitea/models/repo"
  "code.gitea.io/gitea/models/unittest"
  "code.gitea.io/gitea/modules/git"
@@ -221,3 +222,32 @@ func TestWikiRaw(t *testing.T) {
  }
  }
 }
+
+func TestDefaultWikiBranch(t *testing.T) {
+ unittest.PrepareTestEnv(t)
+
+ assert.NoError(t, repo_model.UpdateRepositoryCols(db.DefaultContext, &repo_model.Repository{ID: 1, DefaultWikiBranch: "wrong-branch"}))
+
+ ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki")
+ ctx.SetParams("*", "Home")
+ contexttest.LoadRepo(t, ctx, 1)
+ assert.Equal(t, "wrong-branch", ctx.Repo.Repository.DefaultWikiBranch)
+ Wiki(ctx) // after the visiting, the out-of-sync database record will update the branch name to "master"
+ repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
+ assert.Equal(t, "master", ctx.Repo.Repository.DefaultWikiBranch)
+
+ // invalid branch name should fail
+ assert.Error(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "the bad name"))
+ repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
+ assert.Equal(t, "master", repo.DefaultWikiBranch)
+
+ // the same branch name, should succeed (actually a no-op)
+ assert.NoError(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "master"))
+ repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
+ assert.Equal(t, "master", repo.DefaultWikiBranch)
+
+ // change to another name
+ assert.NoError(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "main"))
+ repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
+ assert.Equal(t, "main", repo.DefaultWikiBranch)
+}
diff --git a/services/repository/migrate.go b/services/repository/migrate.go
@@ -67,7 +67,7 @@ func cloneWiki(ctx context.Context, u *user_model.User, opts migration.MigrateOp
  defaultBranch, err := wikiRepo.GetDefaultBranch()
  if err != nil {
  cleanIncompleteWikiPath()
- return "", fmt.Errorf("failed to get wiki repo defaul branch for %q, err: %w", wikiPath, err)
+ return "", fmt.Errorf("failed to get wiki repo default branch for %q, err: %w", wikiPath, err)
  }
 
  return defaultBranch, nil