From f58e687a83b18d58298097d485f4febf98062dd7 Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 14 Dec 2021 23:50:11 -0800 Subject: [PATCH] Shorten page title in file view (#17987) Move the more relevant sections of the page title earlier which make it possible to distinguish multiple tabs from each other when tab width is limited. Co-authored-by: Lunny Xiao Co-authored-by: wxiaoguang --- routers/web/repo/view.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/routers/web/repo/view.go b/routers/web/repo/view.go index e19fb9bf9189d..45d5a650ba678 100644 --- a/routers/web/repo/view.go +++ b/routers/web/repo/view.go @@ -141,6 +141,10 @@ func renderDirectory(ctx *context.Context, treeLink string) { return } + if ctx.Repo.TreePath != "" { + ctx.Data["Title"] = ctx.Tr("repo.file.title", ctx.Repo.Repository.Name+"/"+path.Base(ctx.Repo.TreePath), ctx.Repo.RefName) + } + // 3 for the extensions in exts[] in order // the last one is for a readme that doesn't // strictly match an extension @@ -374,7 +378,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st } defer dataRc.Close() - ctx.Data["Title"] = ctx.Data["Title"].(string) + " - " + ctx.Tr("repo.file.title", ctx.Repo.TreePath, ctx.Repo.RefName) + ctx.Data["Title"] = ctx.Tr("repo.file.title", ctx.Repo.Repository.Name+"/"+path.Base(ctx.Repo.TreePath), ctx.Repo.RefName) fileSize := blob.Size() ctx.Data["FileIsSymlink"] = entry.IsLink()