-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty URI in logs when using fcgi protocol #14312
Labels
Comments
Found #9473 this previous PR while investigating. |
zeripath
pushed a commit
that referenced
this issue
Jan 13, 2021
a1012112796
added a commit
to a1012112796/gitea
that referenced
this issue
Jan 14, 2021
* master: Use Request.URL.RequestURI() for fcgi (go-gitea#14312) (go-gitea#14314) Update Link [skip ci] Updated translations via Crowdin Kd/add bountysource (go-gitea#14323)
lunny
pushed a commit
that referenced
this issue
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[x]
):Description
When using
PROTOCOL = fcgi
, request paths(http.Request.RequestURI
) are not shown in the logs.Go's
net/http/cgi.RequestFromMap()
, whichnet/http/fcgi
uses, does not populateRequestURI
(but doesURL
). AsRequestURI
is documented "Usually the URL field should be used instead",req.URL.RequestURI()
may be a simple and recommended alternative.gitea/routers/routes/chi.go
Line 89 in 9659808
gitea/routers/routes/chi.go
Line 96 in 9659808
Screenshots
None
The text was updated successfully, but these errors were encountered: