Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "cancel" button when editing Wiki pages #24036

Closed
khorben opened this issue Apr 10, 2023 · 6 comments · Fixed by #29603
Closed

Missing "cancel" button when editing Wiki pages #24036

khorben opened this issue Apr 10, 2023 · 6 comments · Fixed by #29603
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@khorben
Copy link

khorben commented Apr 10, 2023

Description

When editing or creating wiki pages, there is no "Cancel" button helping the user navigate back to the original wiki page, or to the list of wiki pages available, respectively. (See https://try.gitea.io/khorben/test-for-wiki/wiki?action=_new)

Alternatively, Gitea could navigate back into the user's history. On the positive side, nowadays most browsers recognise when information was input but not saved yet, and warn the user before possibly losing this information. However, this would require JavaScript (unless a fallback behaviour is implemented) and break PLA (Principle of Least Astonishment) since it would remove the page edition page from the history, without the user actually interacting with the history buttons ("Back" and "Forward").

Note that this improvement to the User Interface/User eXperience may also apply to new issues. (See https://try.gitea.io/khorben/test-for-wiki/issues/new)

Screenshots

image

Gitea Version

1.16.9

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

NetBSD 9.3_STABLE (GENERIC) pkgsrc-2022Q4 (from source, system service)

Browser Version

Safari 16.3

@khorben khorben added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 10, 2023
@yardenshoham
Copy link
Member

I don't see a reason for a "Cancel" button when you could just navigate away
References:

@khorben
Copy link
Author

khorben commented Apr 10, 2023

I don't see a reason for a "Cancel" button when you could just navigate away

There is no way to go back to the Wiki page currently being edited, except for navigating through the whole Wiki to that page again.

@yardenshoham
Copy link
Member

Can you illustrate with a video/gif?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 11, 2023

I agree with the author.

Think about the case:

  1. Go to wiki list page
  2. Edit a page
  3. Change some thing (but not save)
  4. Now you want to navigate back to the preview page, if you click the "back" button on browser toolbar, you will see an annoying "leave confirm" dialog.

And another case:

  1. Go to wiki list page
  2. Edit a page in new window
  3. You can't navigate back because the new window doesn't have navigation history.

The "cancel" button sometimes is more friendly and intuitive for such page.

@aschrijver
Copy link

Thanks for the heads-up to this issue @wxiaoguang .. I reported the same request in: https://codeberg.org/forgejo/forgejo/issues/705

@wxiaoguang
Copy link
Contributor

Thanks for the heads-up to this issue @wxiaoguang .. I reported the same request in: https://codeberg.org/forgejo/forgejo/issues/705

Thank you for your report, but their fix doesn't seem right, violates the UI design (#28261 (comment)) .... actually it is a quite simple fix, and will be included in #29603

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants