Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVE_DIRECT not functional for container registry #24723

Closed
NOBLES5E opened this issue May 15, 2023 · 1 comment · Fixed by #25543
Closed

SERVE_DIRECT not functional for container registry #24723

NOBLES5E opened this issue May 15, 2023 · 1 comment · Fixed by #25543

Comments

@NOBLES5E
Copy link

Description

Configuration:

[storage.packages]
STORAGE_TYPE               = minio
SERVE_DIRECT               = true
MINIO_ENDPOINT             = [redacted]
MINIO_ACCESS_KEY_ID        = [redacted]
MINIO_SECRET_ACCESS_KEY    = [redacted]
MINIO_BUCKET               = [redacted]
MINIO_LOCATION             = [redacted]
MINIO_USE_SSL              = true
MINIO_INSECURE_SKIP_VERIFY = false

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Running from docker

Database

SQLite

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 27, 2023

The container spec does not allow redirects in the response.

opencontainers/distribution-spec#299 wants to add this. We may just use the redirect and hope for the best. It's a bit strange because the GET endpoints requests specific headers which would be lost with the redirect. Looking at the linked examples that may not be a problem.

KN4CK3R added a commit that referenced this issue Jul 3, 2023
Fixes #24723

Direct serving of content aka HTTP redirect is not mentioned in any of
the package registry specs but lots of official registries do that so it
should be supported by the usual clients.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants