Bad Performance on lagre PRs #26201
Labels
Comments
silverwind
added a commit
that referenced
this issue
Jul 30, 2023
Resizing the comment editor can be a very expensive operation because it triggers page reflows, which on large PRs can take upwards of seconds to complete. Disable this mechanism on the diff page only where we know that the page can get large. Fixes #26201 for the textarea editor. I don't think this can be fixed for EasyMDE because as far as I can tell, it exposes no option to disable this resizing. --------- Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this issue
Jul 31, 2023
Resizing the comment editor can be a very expensive operation because it triggers page reflows, which on large PRs can take upwards of seconds to complete. Disable this mechanism on the diff page only where we know that the page can get large. Fixes go-gitea#26201 for the textarea editor. I don't think this can be fixed for EasyMDE because as far as I can tell, it exposes no option to disable this resizing. --------- Co-authored-by: Giteabot <teabot@gitea.io>
|
Awesome. Your responsetime is impressive :) |
silverwind
added a commit
that referenced
this issue
Jul 31, 2023
Backport #26233 by @silverwind Resizing the comment editor can be a very expensive operation because it triggers page reflows, which on large PRs can take upwards of seconds to complete. Disable this mechanism on the diff page only where we know that the page can get large. Fixes #26201 for the textarea editor. I don't think this can be fixed for EasyMDE because as far as I can tell, it exposes no option to disable this resizing. Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I tried this with the current deployment on try: https://try.gitea.io/thigg/podqast/pulls/1/files
with 85k additions and 12k deletions and even though the site is loading in a matter of 10s of seconds I can not really type comments in there as there is a several seconds lag between typing and seeing the letter on the screen.
I agree that you should not have PRs this big... but if you get into the situation for some reason, it would be nice if at least gitea would not get in your way too.
Also note that this is an extreme example. I can watch our gitea while typing on a 6k LOC review.
To reproduce:Create a large PR, scroll down: click show More twice and try to add a comment. Letters are having now a significant delay between your keypress and appearance on screen.
Gitea Version
1.21.0+dev-410-g7866a6e0e and 1.20.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
It looks like the browser is extremly Slow. I ran the firefox profiler and it says it spends its time in Reflow with get Element.scrollHeight:
Unfortunatley I lack the knowledge to provide further assistance here.
Git Version
No response
Operating System
No response
How are you running Gitea?
apt repository in qemu
Database
None
The text was updated successfully, but these errors were encountered: