Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue edit history sometimes doesn't show the "Delete from history" menu. #27313

Closed
ell1e opened this issue Sep 27, 2023 · 7 comments · Fixed by #27323
Closed

Issue edit history sometimes doesn't show the "Delete from history" menu. #27313

ell1e opened this issue Sep 27, 2023 · 7 comments · Fixed by #27323
Assignees
@wxiaoguang
Labels
type/bug

Comments

@ell1e
Copy link

ell1e commented Sep 27, 2023 •
edited
Loading

Feature Description

A part of the appeal of editing comments is to edit out something you didn't mean to post and don't want to end up in search engine indexes forever on a public repo. (I get it might still be e-mailed and shown to some people but that's not the same at all like it lingering forever on the internet.) However, that only works when it's possible to delete old revisions of your own edited comments, which I'm hereby proposing. GitHub by the way has been offering this for quite a while already. Or alternatively, do it like GitLab and just don't show older versions or any comment history at all. This in between where all older versions of a comment are kept forever but there seems to be no obvious way to delete them seems like a very unfortunate in-between.

Interestingly, the UI to pick and show an old version in a popup where just a single button for deletion would need to be added, is already there. So UI-wise, this change seems really minor. I hope it can be added.

Sure, it's still possible to delete an entire comment instead to "solve" this, but that seems like quite the nuclear option. It would be better to do it like GitHub, where you can delete an old version of the comment but then it also still shows transparently if you check that the older version existed but that it was deleted. That seems like the best of all worlds.

Screenshots

No response
@ell1e ell1e added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Sep 27, 2023
@wxiaoguang
Copy link
Contributor

I do not understand what do you mean.

image

@wxiaoguang wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Sep 28, 2023
@ell1e
Copy link
Author

ell1e commented Sep 28, 2023

Screenshot from 2023-09-28 03-24-24

@wxiaoguang
Copy link
Contributor

I do not know what you are talking about.

image

@ell1e
Copy link
Author

ell1e commented Sep 28, 2023

Ah, my deepest apologies! Was this a recent addition perhaps? It seems like Codeberg is still based on too old Gitea code to show this. In any case, seems like this ticket is invalid, I'm sorry about that.

@ell1e ell1e closed this as completed Sep 28, 2023
@wxiaoguang wxiaoguang reopened this Sep 28, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Sep 28, 2023 •
edited
Loading

Hmm .... good point.

I guess there is a bug. Maybe in some cases, the "delete" menu doesn't show. I will look into it.

Thank you for your report!

@wxiaoguang wxiaoguang self-assigned this Sep 28, 2023
@wxiaoguang wxiaoguang changed the title Not possible to edit older versions of comments with confidential info Issue edit history sometimes doesn't show the "Delete from history" menu. Sep 28, 2023
@wxiaoguang wxiaoguang added type/bug and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Sep 28, 2023
@ell1e
Copy link
Author

ell1e commented Sep 28, 2023

Oh, I'm surprised this isn't just me not checking the server version properly 😅 😂

@wxiaoguang wxiaoguang mentioned this issue Sep 28, 2023
Merged
@wxiaoguang
Copy link
Contributor

The problem is in canSoftDeleteContentHistory, the CanWrite check was incorrect.

-> Improve issue history dialog and make poster can delete their own history #27323

Thank you again.

lunny pushed a commit that referenced this issue Sep 28, 2023
@wxiaoguang
Improve issue history dialog and make poster can delete their own his…
72c6817 
…tory (#27323)

Fix #27313 (see the comment)

And some UI improvements:

### Before


![image](https://github.com/go-gitea/gitea/assets/2114189/420a314d-8f34-4e30-a557-f41cf4f0d2f2)


![image](https://github.com/go-gitea/gitea/assets/2114189/60ca0be4-b55e-4e65-be73-fd53e0d4fc36)


### After


![image](https://github.com/go-gitea/gitea/assets/2114189/d354f815-5a0c-4e63-8d59-d03ed344dbea)


![image](https://github.com/go-gitea/gitea/assets/2114189/6ef437a4-aa6f-4917-a260-00625ee71e79)


![image](https://github.com/go-gitea/gitea/assets/2114189/9d88a36c-616b-4dc9-8c6b-76adaad8acf6)
@GiteaBot GiteaBot mentioned this issue Sep 28, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 28, 2023
@wxiaoguang @GiteaBot
Improve issue history dialog and make poster can delete their own his…
e72454b 
…tory (go-gitea#27323)

Fix go-gitea#27313 (see the comment)

And some UI improvements:

### Before


![image](https://github.com/go-gitea/gitea/assets/2114189/420a314d-8f34-4e30-a557-f41cf4f0d2f2)


![image](https://github.com/go-gitea/gitea/assets/2114189/60ca0be4-b55e-4e65-be73-fd53e0d4fc36)


### After


![image](https://github.com/go-gitea/gitea/assets/2114189/d354f815-5a0c-4e63-8d59-d03ed344dbea)


![image](https://github.com/go-gitea/gitea/assets/2114189/6ef437a4-aa6f-4917-a260-00625ee71e79)


![image](https://github.com/go-gitea/gitea/assets/2114189/9d88a36c-616b-4dc9-8c6b-76adaad8acf6)
lunny pushed a commit that referenced this issue Sep 28, 2023
@GiteaBot @wxiaoguang
Improve issue history dialog and make poster can delete their own his…
71d1bfe 
…tory (#27323) (#27327)

Backport #27323 by @wxiaoguang

Fix #27313 (see the comment)

And some UI improvements:

### Before


![image](https://github.com/go-gitea/gitea/assets/2114189/420a314d-8f34-4e30-a557-f41cf4f0d2f2)


![image](https://github.com/go-gitea/gitea/assets/2114189/60ca0be4-b55e-4e65-be73-fd53e0d4fc36)


### After


![image](https://github.com/go-gitea/gitea/assets/2114189/d354f815-5a0c-4e63-8d59-d03ed344dbea)


![image](https://github.com/go-gitea/gitea/assets/2114189/6ef437a4-aa6f-4917-a260-00625ee71e79)


![image](https://github.com/go-gitea/gitea/assets/2114189/9d88a36c-616b-4dc9-8c6b-76adaad8acf6)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wxiaoguang wxiaoguang

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve issue history dialog and make poster can delete their own history wxiaoguang/gitea
2 participants
@wxiaoguang @ell1e