Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PRs to be marked as WIP (thus preventing them to be accidentally merged) #4453

Closed
gergelypolonkai opened this issue Jul 17, 2018 · 1 comment · Fixed by #4529
Closed
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@gergelypolonkai
Copy link

One thing I really miss from GitLab (I think this feature is non-existent on GitHub) is the ability to mark a pull request as WIP (Work in Progress). All GitLab MRs whose title begins with WIP: is blocked from being merged.

I don’t know if this would fit the plans for Gitea, but it could be definitely helpful for some.

@jonasfranz jonasfranz added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jul 17, 2018
@JulienTant
Copy link
Contributor

Hi, i'm willing to try to implement this in gitea, but before I wanna make sure that you're not working on it on your side.

I imagine building this in two PRs :

  1. Disable to ability to merge a PR when the title starts by WIP: (maybe we can make this configurable ?)
  2. An hypotetical second PR to add "helpers" like :
  • "When the title starts with WIP:, add a button "remove WIP status" that edits the title to remove WIP:
  • When we create a PR, add a description with a link like "Add WIP: to the title to prevent this PR to be accidentally merged"

@lunny lunny added this to the 1.6.0 milestone Aug 2, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants