Issue due-dates are shown in English regardless of current language

[saltymouse]

• Gitea version (or commit ref): d3dc07f
• Git version: 2.17.1
• Operating system: Ubuntu Server 18.04
• Database:
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes https://try.gitea.io/testtestsetset/test-date-format-language/issues
  • No
  • Not relevant
• Log gist:

Description

Due-dates shown on the Issues page are shown in English regardless of the currently used UI language.
Switch to any non-English language (from the language switcher at the bottom of the page) and the dates are still shown in their English format (e.g. Jan 09, 2019)

Somewhat related: Milestone due-dates don't use the same date format as issues but are instead display in a more universal format (e.g. 2019-01-23), so it's more readable in any language, but perhaps they should be unified to use the same date display template?
...

Screenshots

Issues (Japanese UI) shows English language.

Milestones (Japanese UI) shows generic/unformatted date.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[Ryuno-Ki]

The relevant template for issues is

gitea/templates/shared/issuelist.tmpl

Lines 101 to 108 in 73382d2

	{{if ne .DeadlineUnix 0}}
	<span class="due-date tooltip" data-content="{{$.i18n.Tr "repo.issues.due_date"}}" data-position="right center">
	<span{{if .IsOverdue}} class="overdue"{{end}}>
	{{svg "octicon-calendar" 14 "mr-2"}}
	{{.DeadlineUnix.FormatShort}}
	</span>
	</span>
	{{end}}

and for milestones

gitea/templates/repo/issue/milestones.tmpl

Line 80 in 73382d2

<span {{if .IsOverdue}}class="overdue"{{end}}>{{.DeadlineString}}</span>

FormatShort is defined in

gitea/modules/timeutil/timestamp.go

Lines 89 to 92 in 73382d2

	// FormatShort formats as short
	func (ts TimeStamp) FormatShort() string {
	return ts.Format("Jan 02, 2006")
	}

and Deadline in

gitea/models/issues/milestone.go

Line 91 in 73382d2

m.DeadlineString = m.DeadlineUnix.Format("2006-01-02")

I can see timeutil having localised version, but where would I pull the Location information from?

[wxiaoguang]

Two choices:

1. make user can set their timezone in their preference (setting) page.
2. render date/time by frontend (JS)

Each of them has Pros/Cons.

A similar problem: #17760

• Prettify number of issues #17760

[Ryuno-Ki]

Are, the joy of internationalisation. Okay, your PR appears to be almost ready for merge. I'll put this on the backburner for now.

[yardenshoham]

I fixed this