Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed used build tags into version output #828

Closed
jacksgt opened this issue Feb 2, 2017 · 2 comments
Closed

Embed used build tags into version output #828

jacksgt opened this issue Feb 2, 2017 · 2 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@jacksgt
Copy link

jacksgt commented Feb 2, 2017

Hi,

I think it would be nice to be able to view the tags / flags which where used for building this particular Gitea binary.

Nginx has something like this:

$ nginx -V
nginx version: nginx/1.9.10
built with OpenSSL 1.0.2j  26 Sep 2016
TLS SNI support enabled
configure arguments: --with-cc-opt='-g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2' --with-ld-opt='-fPIE -pie -Wl,-z,relro -Wl,-z,now' --prefix=/usr/share/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --lock-path=/var/lock/nginx.lock --pid-path=/run/nginx.pid --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --with-debug --with-pcre-jit --with-ipv6 --with-http_ssl_module --with-http_stub_status_module --with-http_realip_module --with-http_auth_request_module --with-http_addition_module --with-http_dav_module --with-http_geoip_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_image_filter_module --with-http_v2_module --with-http_sub_module --with-http_xslt_module --with-stream --with-stream_ssl_module --with-mail --with-mail_ssl_module --with-threads --add-module=/build/nginx-5VKL9Q/nginx-1.9.10/debian/modules/nginx-auth-pam --add-module=/build/nginx-5VKL9Q/nginx-1.9.10/debian/modules/nginx-dav-ext-module --add-module=/build/nginx-5VKL9Q/nginx-1.9.10/debian/modules/nginx-echo --add-module=/build/nginx-5VKL9Q/nginx-1.9.10/debian/modules/nginx-upstream-fair --add-module=/build/nginx-5VKL9Q/nginx-1.9.10/debian/modules/ngx_http_substitutions_filter_module

Maybe for Gitea something like this could be implemented:

$ gitea -v 
Gitea version 1.0.1 built with: 'bindata' 'pam' 'sqlite'

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lunny lunny added this to the 1.2.0 milestone Feb 3, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 3, 2017
cez81 added a commit to cez81/gitea that referenced this issue Feb 25, 2017
Add build tags to ldflags and print in version output

Signed-off-by: Jonas Östanbäck <jonas.ostanback@gmail.com>
@lunny lunny modified the milestones: 1.1.0, 1.2.0 Feb 25, 2017
lunny pushed a commit that referenced this issue Feb 28, 2017
* Fix for #828
Add build tags to ldflags and print in version output

Signed-off-by: Jonas Östanbäck <jonas.ostanback@gmail.com>

* Reworked formatBuiltWith function

Signed-off-by: Jonas Östanbäck <jonas.ostanback@gmail.com>

* Add tags to version information in admin panel

Signed-off-by: Jonas Östanbäck <jonas.ostanback@gmail.com>

* Added new variable for use on admin page.

Signed-off-by: Jonas Östanbäck <jonas.ostanback@gmail.com>

* Fixed incorrect indentation
@lunny
Copy link
Member

lunny commented Mar 1, 2017

resolved by #1051

@lunny lunny closed this as completed Mar 1, 2017
@jacksgt
Copy link
Author

jacksgt commented Mar 1, 2017

Great work!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

2 participants