Bypass Firefox (iOS) bug #20244
Bypass Firefox (iOS) bug #20244
Conversation
GiteaBot
added
the
lgtm/need 1
|
I have submitted an issue |
| @@ -20,6 +20,11 @@ export function showGlobalErrorMessage(msg) { | |||
| * @param {ErrorEvent} e | |||
| */ | |||
| function processWindowErrorEvent(e) { | |||
| if (!e.error && e.lineno === 0 && e.colno === 0 && e.filename === '' && window.navigator.userAgent.includes('FxiOS/')) { | |||
There was a problem hiding this comment.
Isn't the last condition unnecessary?
It feels less like a workaround without the last condition...
| if (!e.error && e.lineno === 0 && e.colno === 0 && e.filename === '' && window.navigator.userAgent.includes('FxiOS/')) { | |
| if (!e.error && e.lineno === 0 && e.colno === 0 && e.filename === '') { |
There was a problem hiding this comment.
But only Firefox(iOS) has this bug. 'FxiOS/' means Firefox(iOS)
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#firefox_for_ios
Firefox for iOS uses the default Mobile Safari UA string, with an additional FxiOS/ token on iPod and iPhone
There was a problem hiding this comment.
At the moment.
But if Firefox already manages to produce such an obscure bug, why shouldn't the others be able to do that as well?
There was a problem hiding this comment.
I'm fine with both approaches, hence I already approved, but I still wanted to point that out.
There was a problem hiding this comment.
I do not think it could be a general bug for modern browsers. This bug is highly likely to be caused by some incorrect DOM layout handling. The last similar bug in my mind is as old as back to Internet Explorer 6 (20 years ago) ......
GiteaBot
added
lgtm/done
|
Please send backport |
wxiaoguang
added
the
skip-changelog
* go-gitea#20240 At the moment, Firefox (iOS) (10x) has an engine bug. See go-gitea#20240 If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0. This PR ignores such nonsense error event. Fix go-gitea#20240
* upstream/main: Modify milestone search keywords to be case insensitive (go-gitea#20266) Fix toolip on mobile notification bell (go-gitea#20270) Allow RSA 2047 bit keys (go-gitea#20272) Refix notification bell placement (go-gitea#20251) Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256) EscapeFilter the group dn membership (go-gitea#20200) Only show Followers that current user can access (go-gitea#20220) Init popup for new code comment (go-gitea#20234) Bypass Firefox (iOS) bug (go-gitea#20244) Adjust max-widths for the repository file table (go-gitea#20243) Display full name (go-gitea#20171) Adjust class for mobile has the problem of double small bells (go-gitea#20236) Adjust template for go-gitea#20069 smallbell (go-gitea#20108) Add integration tests for the Gitea migration form (go-gitea#20121) Allow dev i18n to be more concurrent (go-gitea#20159) Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
* go-gitea#20240 At the moment, Firefox (iOS) (10x) has an engine bug. See go-gitea#20240 If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0. This PR ignores such nonsense error event. Fix go-gitea#20240
* go-gitea#20240 At the moment, Firefox (iOS) (10x) has an engine bug. See go-gitea#20240 If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0. This PR ignores such nonsense error event. Fix go-gitea#20240
Close #20240
At the moment, Firefox (iOS) (10x) has an engine bug. See #20240
If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0.
This PR ignores such nonsense error event.