Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/generic: Do not restrict package versions to SemVer #20414

Merged
merged 10 commits into from
Jul 28, 2022
Merged

packages/generic: Do not restrict package versions to SemVer #20414

merged 10 commits into from
Jul 28, 2022

Commits on Jul 20, 2022

  1. packages/generic: Do not restrict package versions to SemVer

    There are existing packages out there whose version do not conform to SemVer,
    yet, one would like to have them available in a generic package repository. To
    this end, remove the SemVer restriction on package versions when using the
    Generic package registry, and replace it with a check that simply makes sure the
    version isn't empty.
    
    Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
    algernon committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    8ca3b4a View commit details
    Browse the repository at this point in the history
  2. Update routers/api/packages/generic/generic.go

    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    algernon and KN4CK3R committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    09c9c4d View commit details
    Browse the repository at this point in the history
  3. Update routers/api/packages/generic/generic.go

    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    algernon and KN4CK3R committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    11ea741 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. packages/generic: Use the space-trimmed version string

    Instead of just checking against the space-trimmed version string, return the
    same trimmed version too, so it gets used in that form down the line.
    
    Also add `strings` to the list of imports, because of our use of TrimSpace.
    
    Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
    algernon committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    f7b38ac View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Configuration menu
    Copy the full SHA
    a08a23a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Apply suggestions from code review

    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    6543 and KN4CK3R committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    89067ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ad923f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Make gofmt happy

    Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
    algernon committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    451d2a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Configuration menu
    Copy the full SHA
    cdc0040 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72e4563 View commit details
    Browse the repository at this point in the history