From 85ff5a94a4836c212b91edd6bf9d26a0bbb70adc Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 18 Oct 2022 23:15:05 +0200
Subject: [PATCH 1/2] Disable the 'Add File' button when not able to edit repo

Previously, the button would render a dropdown with zero items when
`.CanEnableEditor` was false. Now it disables the button instead which
is better UX.
---
 templates/repo/home.tmpl | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/templates/repo/home.tmpl b/templates/repo/home.tmpl
index 9d4842579fa1b..cb6d2ff3e85c5 100644
--- a/templates/repo/home.tmpl
+++ b/templates/repo/home.tmpl
@@ -77,25 +77,23 @@
 					<a href="{{.Repository.Link}}/find/{{.BranchNameSubURL}}" class="ui compact basic button tooltip" data-content="{{.locale.Tr "repo.find_file.go_to_file"}}">{{svg "octicon-file-moved" 15}}</a>
 				{{end}}
 				{{if or .CanAddFile .CanUploadFile}}
-					<button class="ui basic small compact dropdown jump icon button mr-2">
+					<button class="ui basic small compact dropdown jump icon button mr-2"{{if not .Repository.CanEnableEditor}} disabled="disabled"{{end}}>
 						<span class="text">{{.locale.Tr "repo.editor.add_file"}}</span>
 						<div class="menu">
-							{{if .Repository.CanEnableEditor}}
-								{{if .CanAddFile}}
-									<a class="item" href="{{.RepoLink}}/_new/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
-										{{.locale.Tr "repo.editor.new_file"}}
-									</a>
-								{{end}}
-								{{if .CanUploadFile}}
-									<a class="item" href="{{.RepoLink}}/_upload/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
-										{{.locale.Tr "repo.editor.upload_file"}}
-									</a>
-								{{end}}
-								{{if .CanAddFile}}
-									<a class="item" href="{{.RepoLink}}/_diffpatch/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
-										{{.locale.Tr "repo.editor.patch"}}
-									</a>
-								{{end}}
+							{{if .CanAddFile}}
+								<a class="item" href="{{.RepoLink}}/_new/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
+									{{.locale.Tr "repo.editor.new_file"}}
+								</a>
+							{{end}}
+							{{if .CanUploadFile}}
+								<a class="item" href="{{.RepoLink}}/_upload/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
+									{{.locale.Tr "repo.editor.upload_file"}}
+								</a>
+							{{end}}
+							{{if .CanAddFile}}
+								<a class="item" href="{{.RepoLink}}/_diffpatch/{{.BranchName | PathEscapeSegments}}/{{.TreePath | PathEscapeSegments}}">
+									{{.locale.Tr "repo.editor.patch"}}
+								</a>
 							{{end}}
 						</div>
 						{{svg "octicon-triangle-down" 14 "dropdown icon"}}

From 9807c97cde366aadad0680fb77ed2628bd5da44f Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 18 Oct 2022 23:19:02 +0200
Subject: [PATCH 2/2] omit attribute value

---
 templates/repo/home.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/repo/home.tmpl b/templates/repo/home.tmpl
index cb6d2ff3e85c5..ff78856047945 100644
--- a/templates/repo/home.tmpl
+++ b/templates/repo/home.tmpl
@@ -77,7 +77,7 @@
 					<a href="{{.Repository.Link}}/find/{{.BranchNameSubURL}}" class="ui compact basic button tooltip" data-content="{{.locale.Tr "repo.find_file.go_to_file"}}">{{svg "octicon-file-moved" 15}}</a>
 				{{end}}
 				{{if or .CanAddFile .CanUploadFile}}
-					<button class="ui basic small compact dropdown jump icon button mr-2"{{if not .Repository.CanEnableEditor}} disabled="disabled"{{end}}>
+					<button class="ui basic small compact dropdown jump icon button mr-2"{{if not .Repository.CanEnableEditor}} disabled{{end}}>
 						<span class="text">{{.locale.Tr "repo.editor.add_file"}}</span>
 						<div class="menu">
 							{{if .CanAddFile}}