Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly flush unique queues on startup #23154

Merged
merged 12 commits into from
Feb 28, 2023
Merged

Properly flush unique queues on startup #23154

merged 12 commits into from
Feb 28, 2023

Commits on Feb 25, 2023

  1. Properly flush unique queues on startup 

    There have been a number of reports of blocked PRs being checked which have been difficult to
debug. In investigating go-gitea#23050 I have realised that whilst the Warn there is somewhat of a
miscall there was a real bug in the way that the LevelUniqueQueue was being restored on
start-up of the PersistableChannelUniqueQueue.

This PR fixes this bug and adds a testcase.

Fix go-gitea#23050
and others

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    a610c89 View commit details
    Browse the repository at this point in the history

  2. Update modules/queue/unique_queue_disk_channel_test.go

    @zeripath
    zeripath committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    9e5ea4c View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. And set the internal queue name for the queues 

    Thanks to brechtvl for noticing this issue!

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    7c99ea6 View commit details
    Browse the repository at this point in the history

  2. Improve test to include some interleaving of queues 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b8fa5cb View commit details
    Browse the repository at this point in the history

  3. Queues need to be named the same - fix TestPersistsableChannelQueue 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    2854448 View commit details
    Browse the repository at this point in the history

  4. adjust logging slightly to remove some more spurious logs 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    a233641 View commit details
    Browse the repository at this point in the history

  5. try to avoid warning and lock issues 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    7396bf7 View commit details
    Browse the repository at this point in the history

  6. avoid logging the channel early shutdown message if the q is not empty 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    efe654d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into fix-23050-ensure-that-unique-queues-get-prop… 

    …erly-restored-on-restart
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    45f417e View commit details
    Browse the repository at this point in the history

  8. fix testcase 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    8cbcff2 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Merge branch 'main' into fix-23050-ensure-that-unique-queues-get-prop… 

    …erly-restored-on-restart
    @zeripath
    zeripath committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    877136d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge branch 'main' into fix-23050-ensure-that-unique-queues-get-prop… 

    …erly-restored-on-restart
    @techknowlogick
    techknowlogick committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a2705dd View commit details
    Browse the repository at this point in the history