From 7b69535a7830de71c33ab4686f98c2ace7f607e6 Mon Sep 17 00:00:00 2001
From: Zettat123 <zettat123@gmail.com>
Date: Tue, 4 Apr 2023 18:06:23 +0800
Subject: [PATCH 1/2] create tag only don't need title

---
 options/locale/locale_en-US.ini | 1 +
 routers/web/repo/release.go     | 6 ++++++
 services/forms/repo_form.go     | 2 +-
 templates/repo/release/new.tmpl | 2 +-
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index 5834703556c29..d35e08e310ebc 100644
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -2307,6 +2307,7 @@ release.tag_helper = Choose an existing tag or create a new tag.
 release.tag_helper_new = New tag. This tag will be created from the target.
 release.tag_helper_existing = Existing tag.
 release.title = Title
+release.title_empty = Title cannot be empty.
 release.content = Content
 release.prerelease_desc = Mark as Pre-Release
 release.prerelease_helper = Mark this release unsuitable for production use.
diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
index b8c5f67f45a7e..6150a0d8cc319 100644
--- a/routers/web/repo/release.go
+++ b/routers/web/repo/release.go
@@ -408,6 +408,12 @@ func NewReleasePost(ctx *context.Context) {
 			return
 		}
 
+		// Title of release cannot be empty
+		if len(form.Title) == 0 {
+			ctx.RenderWithErr(ctx.Tr("repo.release.title_empty"), tplReleaseNew, &form)
+			return
+		}
+
 		rel = &repo_model.Release{
 			RepoID:       ctx.Repo.Repository.ID,
 			Repo:         ctx.Repo.Repository,
diff --git a/services/forms/repo_form.go b/services/forms/repo_form.go
index 3bd073c070d3f..41d7dc7d2b0a9 100644
--- a/services/forms/repo_form.go
+++ b/services/forms/repo_form.go
@@ -693,7 +693,7 @@ type UpdateAllowEditsForm struct {
 type NewReleaseForm struct {
 	TagName    string `binding:"Required;GitRefName;MaxSize(255)"`
 	Target     string `form:"tag_target" binding:"Required;MaxSize(255)"`
-	Title      string `binding:"Required;MaxSize(255)"`
+	Title      string `binding:"MaxSize(255)"`
 	Content    string
 	Draft      string
 	TagOnly    string
diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl
index ea5c70e742859..cd702d6aa6796 100644
--- a/templates/repo/release/new.tmpl
+++ b/templates/repo/release/new.tmpl
@@ -47,7 +47,7 @@
 			<div class="eleven wide column">
 				<div class="field {{if .Err_Title}}error{{end}}">
 					<label>{{.locale.Tr "repo.release.title"}}</label>
-					<input name="title" placeholder="{{.locale.Tr "repo.release.title"}}" value="{{.title}}" autofocus required maxlength="255">
+					<input name="title" placeholder="{{.locale.Tr "repo.release.title"}}" value="{{.title}}" autofocus maxlength="255">
 				</div>
 				<div class="field">
 					<label>{{.locale.Tr "repo.release.content"}}</label>

From d768a44b176bd960662954043020000e80197924 Mon Sep 17 00:00:00 2001
From: Zettat123 <zettat123@gmail.com>
Date: Tue, 4 Apr 2023 18:21:48 +0800
Subject: [PATCH 2/2] fix check

---
 routers/web/repo/release.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
index 6150a0d8cc319..d745fcd084519 100644
--- a/routers/web/repo/release.go
+++ b/routers/web/repo/release.go
@@ -361,6 +361,12 @@ func NewReleasePost(ctx *context.Context) {
 		return
 	}
 
+	// Title of release cannot be empty
+	if len(form.TagOnly) == 0 && len(form.Title) == 0 {
+		ctx.RenderWithErr(ctx.Tr("repo.release.title_empty"), tplReleaseNew, &form)
+		return
+	}
+
 	var attachmentUUIDs []string
 	if setting.Attachment.Enabled {
 		attachmentUUIDs = form.Files
@@ -408,12 +414,6 @@ func NewReleasePost(ctx *context.Context) {
 			return
 		}
 
-		// Title of release cannot be empty
-		if len(form.Title) == 0 {
-			ctx.RenderWithErr(ctx.Tr("repo.release.title_empty"), tplReleaseNew, &form)
-			return
-		}
-
 		rel = &repo_model.Release{
 			RepoID:       ctx.Repo.Repository.ID,
 			Repo:         ctx.Repo.Repository,