From 23de80dbe1b15d5bd3e296187317906923c5aa28 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Thu, 11 May 2023 23:33:18 +0200
Subject: [PATCH 1/5] Improve empty notifications display

---
 templates/user/notification/notification_div.tmpl | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl
index b8efd2433e8c8..2abf398cb6e86 100644
--- a/templates/user/notification/notification_div.tmpl
+++ b/templates/user/notification/notification_div.tmpl
@@ -1,6 +1,6 @@
 <div role="main" aria-label="{{.Title}}" class="page-content user notification" id="notification_div" data-params="{{.Page.GetParams}}" data-sequence-number="{{.SequenceNumber}}">
 	<div class="ui container">
-		<h1 class="ui dividing header">{{.locale.Tr "notification.notifications"}}</h1>
+		<h1 class="ui header">{{.locale.Tr "notification.notifications"}}</h1>
 		<div class="ui top attached tabular menu">
 			{{$notificationUnreadCount := call .NotificationUnreadCount}}
 			<a href="{{AppSubUrl}}/notifications?q=unread" class="{{if eq .Status 1}}active {{end}}item">
@@ -23,11 +23,14 @@
 		</div>
 		<div class="ui bottom attached active tab segment gt-p-3">
 			{{if eq (len .Notifications) 0}}
-				{{if eq .Status 1}}
-					{{.locale.Tr "notification.no_unread"}}
-				{{else}}
-					{{.locale.Tr "notification.no_read"}}
-				{{end}}
+				<div class="gt-df gt-ac gt-jc gt-fc gt-p-4 gt-tc">
+					{{svg "octicon-inbox" 48 "gt-mb-3"}}
+					{{if eq .Status 1}}
+						{{.locale.Tr "notification.no_unread"}}
+					{{else}}
+						{{.locale.Tr "notification.no_read"}}
+					{{end}}
+				</div>
 			{{else}}
 				<table class="ui unstackable very compact small table" id="notification_table">
 					<tbody>

From 2ab5a796eb0fa83113291dca25946f167d11d921 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Thu, 11 May 2023 23:39:01 +0200
Subject: [PATCH 2/5] remove useless classes

---
 templates/user/notification/notification_div.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl
index 2abf398cb6e86..7e47d1895813a 100644
--- a/templates/user/notification/notification_div.tmpl
+++ b/templates/user/notification/notification_div.tmpl
@@ -23,7 +23,7 @@
 		</div>
 		<div class="ui bottom attached active tab segment gt-p-3">
 			{{if eq (len .Notifications) 0}}
-				<div class="gt-df gt-ac gt-jc gt-fc gt-p-4 gt-tc">
+				<div class="gt-df gt-ac gt-fc gt-p-4">
 					{{svg "octicon-inbox" 48 "gt-mb-3"}}
 					{{if eq .Status 1}}
 						{{.locale.Tr "notification.no_unread"}}

From 84692fce814538a527fe4e978ae96672ed643930 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Thu, 11 May 2023 23:41:49 +0200
Subject: [PATCH 3/5] slight icon size increase

---
 templates/user/notification/notification_div.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl
index 7e47d1895813a..6f065185a7dc8 100644
--- a/templates/user/notification/notification_div.tmpl
+++ b/templates/user/notification/notification_div.tmpl
@@ -24,7 +24,7 @@
 		<div class="ui bottom attached active tab segment gt-p-3">
 			{{if eq (len .Notifications) 0}}
 				<div class="gt-df gt-ac gt-fc gt-p-4">
-					{{svg "octicon-inbox" 48 "gt-mb-3"}}
+					{{svg "octicon-inbox" 56 "gt-mb-4"}}
 					{{if eq .Status 1}}
 						{{.locale.Tr "notification.no_unread"}}
 					{{else}}

From a8f2f80eaacd07100ec12ac3226571c875cc7885 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Fri, 12 May 2023 00:13:42 +0200
Subject: [PATCH 4/5] few more tweaks

---
 templates/user/notification/notification_div.tmpl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl
index 6f065185a7dc8..3ce8c8e534601 100644
--- a/templates/user/notification/notification_div.tmpl
+++ b/templates/user/notification/notification_div.tmpl
@@ -1,6 +1,9 @@
 <div role="main" aria-label="{{.Title}}" class="page-content user notification" id="notification_div" data-params="{{.Page.GetParams}}" data-sequence-number="{{.SequenceNumber}}">
 	<div class="ui container">
-		<h1 class="ui header">{{.locale.Tr "notification.notifications"}}</h1>
+		<h1 class="ui header gt-df gt-ac">
+			{{svg "octicon-bell" 28 "gt-mr-3 gt-mt-1"}}
+			{{.locale.Tr "notification.notifications"}}
+		</h1>
 		<div class="ui top attached tabular menu">
 			{{$notificationUnreadCount := call .NotificationUnreadCount}}
 			<a href="{{AppSubUrl}}/notifications?q=unread" class="{{if eq .Status 1}}active {{end}}item">
@@ -24,7 +27,7 @@
 		<div class="ui bottom attached active tab segment gt-p-3">
 			{{if eq (len .Notifications) 0}}
 				<div class="gt-df gt-ac gt-fc gt-p-4">
-					{{svg "octicon-inbox" 56 "gt-mb-4"}}
+					{{svg "octicon-check" 56 "gt-mb-4"}}
 					{{if eq .Status 1}}
 						{{.locale.Tr "notification.no_unread"}}
 					{{else}}

From 252037ce7d00aa8b9b71db0eb8c87364f5b41770 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Fri, 12 May 2023 00:23:10 +0200
Subject: [PATCH 5/5] switch back to inbox

---
 templates/user/notification/notification_div.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl
index 3ce8c8e534601..6047f34580e54 100644
--- a/templates/user/notification/notification_div.tmpl
+++ b/templates/user/notification/notification_div.tmpl
@@ -27,7 +27,7 @@
 		<div class="ui bottom attached active tab segment gt-p-3">
 			{{if eq (len .Notifications) 0}}
 				<div class="gt-df gt-ac gt-fc gt-p-4">
-					{{svg "octicon-check" 56 "gt-mb-4"}}
+					{{svg "octicon-inbox" 56 "gt-mb-4"}}
 					{{if eq .Status 1}}
 						{{.locale.Tr "notification.no_unread"}}
 					{{else}}