Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility when (re-)viewing files #24817

Merged
merged 12 commits into from
May 21, 2023

Commits on May 20, 2023

  1. Improve accessibility when (re-)viewing files

    Visually, nothing should have changed.
    Changes include
    - Convert most `<a [no href]>` to `<button>` when (re-)viewing files
    - `<a class="ui button">` can now be clicked (again?) using <kbd>Enter</kbd>
    - The `(un)escape file`, the `expand section` and the `expand/collapse file`
      buttons can now be focused (and subsequently clicked using only the keyboard)
    - Previously, pressing <kbd>Space</kbd> on the `View file` checkbox did
      nothing as this checkbox listened to the wrong event listener.
      Now, you can use the keyboard for this checkbox too.
    
    The `add code comment` button has been left inaccessible for now as it
    requires quite a bit of extra logic so that it is unhidden when it is
    focused (you can otherwise focus it without seeing it as you are not
    hovering on the corresponding line).
    delvh authored and silverwind committed May 20, 2023
    Configuration menu
    Copy the full SHA
    8039a09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9db226 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    840f20a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc2c7e9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    919d6e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ac6a6ae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    abd9756 View commit details
    Browse the repository at this point in the history
  8. Center the newly created excerpts too

    delvh authored and silverwind committed May 20, 2023
    Configuration menu
    Copy the full SHA
    29733fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    306767b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b899d48 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4e72975 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Configuration menu
    Copy the full SHA
    c4a5d9e View commit details
    Browse the repository at this point in the history