Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic VSCode configuration for building and debugging #2483

Merged
merged 3 commits into from
Sep 12, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Sep 10, 2017

I know that there are many options for IDE/code editors developing Go but it would make easier for new developers to get going by providing at least basic configuration for building and debugging out of box.

@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Sep 10, 2017
@lunny
Copy link
Member

lunny commented Sep 11, 2017

LGTM, I'm using VSCode.

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 11, 2017
@Morlinest
Copy link
Member

I am using vscode too, but don't think any IDE setup should be included in project codebase. You can add it to README or create wiki page about it.

@bkcsoft
Copy link
Member

bkcsoft commented Sep 11, 2017

Yeah, add this to scripts/ instead (and maybe change that to support/ ?)

"panel": "shared"
},
"args": ["build", "-o", "gitea", "${workspaceRoot}/main.go"],
"windows": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work for me on Windows. Looks like it's combing both sets of args.

> Executing task: go build -o gitea c:\Users\Jonas\go\src\code.gitea.io\gitea/main.go build -o gitea.exe c:\Users\Jonas\go\src\code.gitea.io\gitea/main.go <

named files must be .go files
The terminal process terminated with exit code: 1

@pgaskin
Copy link
Contributor

pgaskin commented Sep 11, 2017

LGTM, I'm using VSCode on Debian, and this works for me.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2017
@lafriks
Copy link
Member Author

lafriks commented Sep 11, 2017

@cez81 fixed for windows

@lafriks
Copy link
Member Author

lafriks commented Sep 11, 2017

@Morlinest @bkcsoft my idea was for new developers to get going faster and it does not mess anything if you are other IDE/editor but off course I can move it to contrib also but that would not be much of the help as most probably anyone rarely looks in that folder :)

@cez81
Copy link
Contributor

cez81 commented Sep 11, 2017

@lafriks Works 👍

I think it can be moved to contrib folder but should be accompanied with support docs to get people started.

@lafriks
Copy link
Member Author

lafriks commented Sep 11, 2017

@sapk @Morlinest @bkcsoft done

@Morlinest
Copy link
Member

@lafriks Thanks for all your work (I will probably use it too :D).

I want to share my opinion:
I am glad you want to help new developers and I appreciate that. Great help would be updated readme with manual/examples as this is first document anyone sees and reads (and there is nothing about how to run, develop or debug gitea - "contributors guide" is mentioned, but it doesn't contain any usefull command for me). You can add example configuration for any ide. The best way for me is to add it to different folder (as your updated PR) or documentation like wiki or directly to readme file. Yes, it will not conflict with other IDE if you add it to project, but what about people that want to use vscode with their own setup?

Another thing, there is makefile for help with everything and I am missing any documentation for that. This (documentation for makefile and what commands should I use and when) would be for me best first help.

@lafriks
Copy link
Member Author

lafriks commented Sep 11, 2017

@Morlinest yes I agree that others could want to modify or add additional tasks that's why I moved it to contrib folder :) Also that is reason why I added link to IDE configuration on top of contribution file to not bury it somewhere deep :)

@lafriks
Copy link
Member Author

lafriks commented Sep 12, 2017

Make LG-TM work

@lunny lunny merged commit 4c2b1be into go-gitea:master Sep 12, 2017
@lafriks lafriks deleted the feat/basic_vscode_tasks branch September 12, 2017 12:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants