Fix ::User Profile Page - Project/Packages Tabs Have Inconsistent Layout

[puni9869]

Fix ::User Profile Page Project Tab Have Inconsistent Layout and Style
Added the big_avator for consistency in the all header_items tabs.

#24871

Description

in the user profile page the Packages and Projects tab have small icons for user but other tabs have bigger profile picture with user info:

Screenshots

For Packages And Projects:

For Other Tabs:

Before

After changes

Project View

Packages View

Org view for projects page

Org view for packages page

[puni9869]

@silverwind

[silverwind]

Not sure if related to this PR, but I fixed this issue in e0813ef:

[silverwind]

You missed the Code tab which you can see when enabling the repo indexer in app.ini:

[indexer]
REPO_INDEXER_ENABLED = true
REPO_INDEXER_PATH    = indexers/repos.bleve

It still renders full width. Please give it the same treatment.

Other than that, I think this looks good from a quick test.

[puni9869]

Not sure if related to this PR, but I fixed this issue in e0813ef:

This is needed.

[silverwind]

You mean for the code tab? Yes I could do it there as well. Also, I see I missed the all option in the package selection field, will correct later.

[puni9869]

Exactly,
You take it forward for merge and further fix [if any tiniest fix required from your side]. I think Fix ::User Profile Page - Project/Packages Tabs Have Inconsistent Layout is done with the functionality.

Thanks @silverwind for the support.

[silverwind]

@puni9869 Some issues:

1. "Projects" tab is missing while "Code" tab is active:

2. On "Projects" tab, the tab bar's line is too wide, streching beyond the navbar even:

Can the tab bar template be shared to avoid these and future issues where these templates go out of sync?

Code tab search looks alright and does not flash incorrect content, so needs no adjustment imho.

[silverwind]

Also, I see I missed the all option in the package selection field, will correct later.

Fixed this in cc79eba.

[puni9869]

That headerbar template is shared among all
I'll fix it asap.

[silverwind]

Appears to work fine now.

[yekanchi]

looks good to me 2, thatnks

[puni9869]

Can we get one more approval.

[wxiaoguang]

The name and usage seems not ideal.

• The name: it doesn't "render", it only prepares some data
• If the response has been written in it, the caller shouldn't continue (by checking Written)

[puni9869]

Correct, and I am even in favour of changing the naming pattern, but when I see https://github.com/go-gitea/gitea/pull/25108/files/6c990c4da74a329f700ffffaa5ddfa1d6195fd7b#diff-f4279417070a8e33829c338abeb42877500377f490abb1495ae6357d50b6a765R92 in the same function doing something like that and implementation looks like this

gitea/routers/web/shared/user/header.go

Line 13 in e24f651

func RenderUserHeader(ctx *context.Context) {

,
I don't want to break the pattern, if you are suggesting an explicit change in function, that I can.

In short maintainability is the real concern here.

Could you suggest something which is easier for maintainers. I have less knowledge on naming conventions.

[wxiaoguang]

Well, the old code is buggy, so I won't say it is a must now.

[wxiaoguang]

That's too hacky. Why "IsOrganization" means "container"?

[silverwind]

If possible, remove the container.

[puni9869]

Unfortunately container cannot be removed, it is hacky beause we are sharing this between repository and orgransation page. I tried removing it but it will mass the whole project tab design in org view.

[silverwind]

Ok, it might be an acceptable compromise then. Didn't check the details.

[wxiaoguang]

My opinion is that these if-else tricks are too fragile, so I can't vote my approval, while I won't block if others like it and approve.

[puni9869]

There are some major conflicts in this PR. Will re-write this in follow up PR.