Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document creating an API key from the CLI #25504

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Document creating an API key from the CLI #25504

merged 2 commits into from
Jun 26, 2023

Conversation

lonix1
Copy link
Contributor

@lonix1 lonix1 commented Jun 25, 2023

Related to #25503

@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2023
@delvh delvh changed the title Docs: Create API key via CLI Document creating an API key from the CLI Jun 25, 2023
@lonix1
Copy link
Contributor Author

lonix1 commented Jun 25, 2023

I'm unfamiliar with the review system delvh, I hope I clicked the right button!

@delvh
Copy link
Member

delvh commented Jun 25, 2023

Oh, by the way, please cherrypick this PR also to main once it is merged.
Otherwise, it would be lost once 1.20 is outdated.

@delvh
Copy link
Member

delvh commented Jun 25, 2023

I hope I clicked the right button!

Yup, that was the correct one.

@lonix1
Copy link
Contributor Author

lonix1 commented Jun 25, 2023

Sorry you are now talking "above my pay grade". I'm not a git expert unfortunately. I will look into it...

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 25, 2023

You targeted the 1.20 branch instead of main. Usually changed are made in the main branch and backported into the other relevant branches and not the other way around.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@lunny lunny added type/docs This PR mainly updates/creates documentation backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 26, 2023
@GiteaBot GiteaBot removed the backport/v1.20 This PR should be backported to Gitea 1.20 label Jun 26, 2023
@lonix1
Copy link
Contributor Author

lonix1 commented Jun 26, 2023

Thanks... I understand now.

BTW I just clicked the "edit" button on the docs page, and accepted all the defaults.

I don't have a cherrypick option here, so I assume I'll need to redo it.

@techknowlogick
Copy link
Member

@lonix1 I will cherry pick it for you. Thanks for your contribution :)

@techknowlogick techknowlogick merged commit 5703a0d into go-gitea:release/v1.20 Jun 26, 2023
20 checks passed
@lonix1 lonix1 deleted the patch-1 branch June 26, 2023 01:56
techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Jun 26, 2023
Related to go-gitea#25503

---------

Co-authored-by: delvh <dev.lh@web.de>
techknowlogick added a commit that referenced this pull request Jun 26, 2023
Frontport of #25504

Credit to @lonix1

Co-authored-by: lonix1 <40320097+lonix1@users.noreply.github.com>
Co-authored-by: delvh <dev.lh@web.de>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants