Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the reason why the user can't add a new email if there is a pending activation #25509

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Clarify the reason why the user can't add a new email if there is a pending activation #25509

merged 2 commits into from
Jun 26, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 26, 2023 •
edited
Loading

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2023
@wxiaoguang wxiaoguang mentioned this pull request Jun 26, 2023
Closed
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jun 26, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 26, 2023
@lunny lunny enabled auto-merge (squash) June 26, 2023 04:04
@lunny lunny merged commit d5f0075 into go-gitea:main Jun 26, 2023
22 checks passed
@GiteaBot GiteaBot mentioned this pull request Jun 26, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 26, 2023
@wxiaoguang @GiteaBot
Clarify the reason why the user can't add a new email if there is a p…
209ae60 
…ending activation (go-gitea#25509)

![image](https://github.com/go-gitea/gitea/assets/2114189/cff20df0-ad0c-4140-b8e2-5782cad8a53a)
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 26, 2023
@wxiaoguang wxiaoguang deleted the improve-email branch June 26, 2023 04:54
lunny pushed a commit that referenced this pull request Jun 26, 2023
@GiteaBot @wxiaoguang
Clarify the reason why the user can't add a new email if there is a p…
53747a5 
…ending activation (#25509) (#25514)

Backport #25509 by @wxiaoguang


![image](https://github.com/go-gitea/gitea/assets/2114189/cff20df0-ad0c-4140-b8e2-5782cad8a53a)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 1, 2023

Is a user able to revoke a pending activation? If the user used a non-existing email address, there must be a way to correct this (for example by revoking and creating a new email).

@wxiaoguang
Copy link
Contributor Author

At the moment, no, they have to wait for 180 seconds (3 minutes) before the pending activation expires.

That's a longstanding problem, this PR only clarify the problem.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 1, 2023

Alright, just wanted to make sure a user can add a new email in case of an error.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @KN4CK3R @lunny @techknowlogick @GiteaBot