Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport locales to v1.20 #25899

Merged
merged 5 commits into from
Jul 15, 2023
Merged

Backport locales to v1.20 #25899

merged 5 commits into from
Jul 15, 2023

Conversation

denyskon
Copy link
Member

No description provided.

@GiteaBot GiteaBot added this to the 1.20.0 milestone Jul 15, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2023
delvh
delvh previously approved these changes Jul 15, 2023
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2023
wxiaoguang
wxiaoguang requested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this backport is wrong because the _package_.documentation strings are all broken.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jul 15, 2023
@delvh delvh dismissed their stale review July 15, 2023 14:03

see @wxiaoguang s message

@denyskon
Copy link
Member Author

@wxiaoguang What do you mean? Why are they broken?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 15, 2023 •
edited
Loading

See #25638 (comment)

And Remove broken translations #25737

@yardenshoham yardenshoham self-requested a review July 15, 2023 14:07
@denyskon denyskon requested a review from wxiaoguang July 15, 2023 14:22
@GiteaBot GiteaBot removed the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Jul 15, 2023
@denyskon denyskon requested a review from delvh July 15, 2023 14:22
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2023
@denyskon
Copy link
Member Author

I removed the broken translations

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 15, 2023
@techknowlogick techknowlogick merged commit f7e271f into go-gitea:release/v1.20 Jul 15, 2023
20 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 15, 2023
@denyskon denyskon deleted the backport/locales-1.20 branch July 15, 2023 15:30
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@denyskon @wxiaoguang @yardenshoham @delvh @techknowlogick @GiteaBot