Apply min-height in wiki only on preview pane #28687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the commit 5a56f96 (3.) the min-height was applied to all wiki elements. This resulted in huge blank spaces when viewing the wiki. This fixes this by only applying the min-height to the preview when editing. Refs: https://codeberg.org/forgejo/forgejo/pulls/2080 (cherry picked from commit 8f0baefe5dadc929fe7456c36c8b205e96f228f0)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
approved these changes
Jan 3, 2024
GiteaBot
added
lgtm/need 1
KN4CK3R
approved these changes
Jan 3, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 5, 2024
* giteaofficial/main: Add links to owner home page in explore (go-gitea#28341) Apply min-height in wiki only on preview pane (go-gitea#28687)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
In the commit 5a56f96 (3.) the min-height was applied to all wiki elements. This resulted in huge blank spaces when viewing the wiki. This fixes this by only applying the min-height to the preview when editing. Refs: https://codeberg.org/forgejo/forgejo/pulls/2080 (cherry picked from commit 8f0baefe5dadc929fe7456c36c8b205e96f228f0) Co-authored-by: Fl1tzi <git@fl1tzi.com>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
In the commit 5a56f96 (3.) the min-height was applied to all wiki elements. This resulted in huge blank spaces when viewing the wiki. This fixes this by only applying the min-height to the preview when editing. Refs: https://codeberg.org/forgejo/forgejo/pulls/2080 (cherry picked from commit 8f0baefe5dadc929fe7456c36c8b205e96f228f0) Co-authored-by: Fl1tzi <git@fl1tzi.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit 5a56f96 (3.) the min-height was applied to all wiki elements. This resulted in huge blank spaces when viewing the wiki.
This fixes this by only applying the min-height to the preview when editing.
Refs: https://codeberg.org/forgejo/forgejo/pulls/2080
(cherry picked from commit 8f0baefe5dadc929fe7456c36c8b205e96f228f0)