Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeowner detected diff base branch to mergebase (#29783) #29807

Merged
merged 8 commits into from
Mar 17, 2024
Merged

Fix codeowner detected diff base branch to mergebase (#29783) #29807

merged 8 commits into from
Mar 17, 2024

Commits on Mar 15, 2024

  1. Fix codeowner detected diff base branch to mergebase (go-gitea#29783) 

    Fix go-gitea#29763

This PR fixes 2 problems with CodeOwner in the pull request.
- Don't use the pull request base branch but merge-base as a diff base to
detect the code owner.
- CodeOwner detection in fork repositories will be disabled because
almost all the fork repositories will not change CODEOWNERS files but it
should not be used on fork repositories' pull requests.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
    @lunny @wxiaoguang
    lunny and wxiaoguang committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d30950d View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @lunny
    lunny committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dbeb2d0 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @lunny
    lunny committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    27c15e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Fix test

    @lunny
    lunny committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    9278e3c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.21' into lunny/fix_codeowner2

    @lunny
    lunny committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e94dacb View commit details
    Browse the repository at this point in the history

  3. Fix test

    @lunny
    lunny committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    c96d09b View commit details
    Browse the repository at this point in the history

  4. Fix test

    @lunny
    lunny committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    a44bfd9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'release/v1.21' into lunny/fix_codeowner2

    @6543
    6543 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    dec918b View commit details
    Browse the repository at this point in the history