Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go 1.22 and upgrade dependency #29869

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Upgrade Go 1.22 and upgrade dependency #29869

merged 3 commits into from
Mar 17, 2024

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 17, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/dependencies labels Mar 17, 2024
denyskon
denyskon approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(assuming tests pass 😄 )

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 17, 2024 15:14
@wxiaoguang wxiaoguang changed the title Upgrade Go and dependency Upgrade Go 1.22 and upgrade dependency Mar 17, 2024
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2024
@wxiaoguang wxiaoguang merged commit abb330e into go-gitea:main Mar 17, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2024
@wxiaoguang wxiaoguang deleted the upgrade-go branch March 17, 2024 15:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ea2609e 
* giteaofficial/main:
  Fix missing error check of bufio.Scanner (go-gitea#29882)
  Remove unused error in graceful manager (go-gitea#29871)
  Migrate border and margin classes to Tailwind (go-gitea#29828)
  Only do counting when count_only=true for repo dashboard (go-gitea#29884)
  Editor error message misleading due to re-used key. (go-gitea#29859)
  [skip ci] Updated licenses and gitignores
  move some scripts from 'build' to 'tools' directory, misc refactors (go-gitea#29844)
  Fix missing code in the user profile (go-gitea#29865)
  Upgrade Go 1.22 and upgrade dependency (go-gitea#29869)
  Fix the wrong locale key of searching users (go-gitea#29868)
  fix telegram webhook (go-gitea#29864)
  Fix user id column case (go-gitea#29863)
  Avoid JS error on issue/pr list when logged out (go-gitea#29854)
  Refactor clone-panel styles (go-gitea#29861)
  Simplify README (go-gitea#29827)
  Load citation JS only when needed (go-gitea#29855)
  Fix semantic.json (go-gitea#29860)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
@Darthagnon
Copy link

Darthagnon commented Jun 8, 2024 •
edited
Loading

Bumping the Golang version to v1.22 breaks compatibility with older Windows hosts. Golang v1.21.4 is the last version that works with Windows 7 / Server 2008 hosts. It is an operating system unsupported by the manufacturer (community support is still pretty good), but does this version bump add enough features worth breaking compatibility with several generations of machines? Will compatibility be dropped in future for Windows 10 after it loses support next year?

@delvh
Copy link
Member

delvh commented Jun 8, 2024

Well… yes, probably.
Running Gitea on an unsupported system is not supported.
If you still want support for outdated systems, your only bet is commercial support from the Gitea Ltd (ping @techknowlogick, perhaps you are the right contact for that) or similar.
After all, in most cases there's a reason why systems are being made EOL: too much changed since then, and it is expected that it has multiple unfixed problems.
(TBF, Windows 10 might be an outlier there. Let's see if Microsoft doesn't backtrack, Windows 10 shouldn't be obsolete yet.)

Gitea has only a single explicit requirement: git >= 2.0.0, when you're not using gogit.
For everything else, we only support what is still supported anyway (i.e. maintained DBs, maintained OSes, …).
If Go decides to drop Windows 7 support, then argue with them about it.
Gitea will continue to follow Go.
I don't see the need to deviate from them.
Deviating would kill the project with maintenance overhead.

@GiteaBot
Copy link
Contributor

We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/dependencies modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @Darthagnon @delvh @GiteaBot @denyskon