Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webpack EnvironmentPlugin #32661

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Add webpack EnvironmentPlugin #32661

merged 2 commits into from
Nov 28, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 28, 2024 •
edited
Loading

Fixes: #32660

Environment vars in Webpack need to be declared in the config, otherwise they will not be elimininated during compilation.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2024
@silverwind silverwind mentioned this pull request Nov 28, 2024
Closed
silverwind
silverwind commented Nov 28, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 28, 2024
@silverwind silverwind enabled auto-merge (squash) November 28, 2024 01:50
@silverwind silverwind merged commit f1bea3c into go-gitea:main Nov 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 28, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 28, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 28, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 28, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 28, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d522007 
* giteaofficial/main:
  Allow cropping an avatar before setting it (go-gitea#32565)
  Add webpack EnvironmentPlugin (go-gitea#32661)
  Move team related functions to service layer (go-gitea#32537)
  Make frontend unit test code could know it is in testing (go-gitea#32656)
  Add priority to protected branch (go-gitea#32286)
@wxiaoguang wxiaoguang mentioned this pull request Nov 29, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

JS error when creating an issue
5 participants
@silverwind @techknowlogick @yp05327 @wxiaoguang @GiteaBot