From c970c7840db510fb0a669b19da7dc60070675b68 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 14 May 2019 14:00:53 +0800 Subject: [PATCH 1/3] move xorm logger bridge from log to models so that log module could be a standalone package --- modules/log/xorm.go => models/log.go | 46 +++++++++++++--------------- models/models.go | 5 ++- modules/setting/log.go | 3 -- 3 files changed, 23 insertions(+), 31 deletions(-) rename modules/log/xorm.go => models/log.go (68%) diff --git a/modules/log/xorm.go b/models/log.go similarity index 68% rename from modules/log/xorm.go rename to models/log.go index c08b7fd7d5463..c2eeaeaad7f17 100644 --- a/modules/log/xorm.go +++ b/models/log.go @@ -2,11 +2,12 @@ // Use of this source code is governed by a MIT-style // license that can be found in the LICENSE file. -package log +package models import ( "fmt" + "code.gitea.io/log" "github.com/go-xorm/core" ) @@ -16,78 +17,73 @@ type XORMLogBridge struct { level core.LogLevel } -var ( - // XORMLogger the logger for xorm - XORMLogger *XORMLogBridge -) - -// InitXORMLogger inits a log bridge for xorm -func InitXORMLogger(showSQL bool) { - XORMLogger = &XORMLogBridge{ +// NeXORMLogger inits a log bridge for xorm +func NeXORMLogger(showSQL bool) core.ILogger { + return &XORMLogBridge{ showSQL: showSQL, } } // GetGiteaLevel returns the minimum Gitea logger level -func (l *XORMLogBridge) GetGiteaLevel() Level { - return GetLogger("xorm").GetLevel() +func (l *XORMLogBridge) GetGiteaLevel() log.Level { + return log.GetLogger("xorm").GetLevel() } // Log a message with defined skip and at logging level -func (l *XORMLogBridge) Log(skip int, level Level, format string, v ...interface{}) error { - return GetLogger("xorm").Log(skip+1, level, format, v...) +func (l *XORMLogBridge) Log(skip int, level log.Level, format string, v ...interface{}) error { + return log.GetLogger("xorm").Log(skip+1, level, format, v...) } // Debug show debug log func (l *XORMLogBridge) Debug(v ...interface{}) { - l.Log(2, DEBUG, fmt.Sprint(v...)) + l.Log(2, log.DEBUG, fmt.Sprint(v...)) } // Debugf show debug log func (l *XORMLogBridge) Debugf(format string, v ...interface{}) { - l.Log(2, DEBUG, format, v...) + l.Log(2, log.DEBUG, format, v...) } // Error show error log func (l *XORMLogBridge) Error(v ...interface{}) { - l.Log(2, ERROR, fmt.Sprint(v...)) + l.Log(2, log.ERROR, fmt.Sprint(v...)) } // Errorf show error log func (l *XORMLogBridge) Errorf(format string, v ...interface{}) { - l.Log(2, ERROR, format, v...) + l.Log(2, log.ERROR, format, v...) } // Info show information level log func (l *XORMLogBridge) Info(v ...interface{}) { - l.Log(2, INFO, fmt.Sprint(v...)) + l.Log(2, log.INFO, fmt.Sprint(v...)) } // Infof show information level log func (l *XORMLogBridge) Infof(format string, v ...interface{}) { - l.Log(2, INFO, format, v...) + l.Log(2, log.INFO, format, v...) } // Warn show warning log func (l *XORMLogBridge) Warn(v ...interface{}) { - l.Log(2, WARN, fmt.Sprint(v...)) + l.Log(2, log.WARN, fmt.Sprint(v...)) } // Warnf show warnning log func (l *XORMLogBridge) Warnf(format string, v ...interface{}) { - l.Log(2, WARN, format, v...) + l.Log(2, log.WARN, format, v...) } // Level get logger level func (l *XORMLogBridge) Level() core.LogLevel { switch l.GetGiteaLevel() { - case TRACE, DEBUG: + case log.TRACE, log.DEBUG: return core.LOG_DEBUG - case INFO: + case log.INFO: return core.LOG_INFO - case WARN: + case log.WARN: return core.LOG_WARNING - case ERROR, CRITICAL: + case log.ERROR, log.CRITICAL: return core.LOG_ERR } return core.LOG_OFF diff --git a/models/models.go b/models/models.go index 352c07e0c3f03..15134fecf1701 100644 --- a/models/models.go +++ b/models/models.go @@ -15,7 +15,6 @@ import ( "path/filepath" "strings" - "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" // Needed for the MySQL driver @@ -261,7 +260,7 @@ func NewTestEngine(x *xorm.Engine) (err error) { } x.SetMapper(core.GonicMapper{}) - x.SetLogger(log.XORMLogger) + x.SetLogger(NeXORMLogger(!setting.ProdMode)) x.ShowSQL(!setting.ProdMode) return x.StoreEngine("InnoDB").Sync2(tables...) } @@ -276,7 +275,7 @@ func SetEngine() (err error) { x.SetMapper(core.GonicMapper{}) // WARNING: for serv command, MUST remove the output to os.stdout, // so use log file to instead print to stdout. - x.SetLogger(log.XORMLogger) + x.SetLogger(NeXORMLogger(setting.LogSQL)) x.ShowSQL(setting.LogSQL) return nil } diff --git a/modules/setting/log.go b/modules/setting/log.go index cd2c5cc8c163e..43a28309d26dd 100644 --- a/modules/setting/log.go +++ b/modules/setting/log.go @@ -295,8 +295,5 @@ func NewXORMLogService(disableConsole bool) { Cfg.Section("log").Key("XORM").MustString(",") generateNamedLogger("xorm", options) - log.InitXORMLogger(LogSQL) - } else { - log.InitXORMLogger(false) } } From 2b68c6607e0bf78338e4faacd82ebc5f8d461ecd Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 14 May 2019 14:06:25 +0800 Subject: [PATCH 2/3] fix tests --- models/log.go | 7 ++++--- models/models.go | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/models/log.go b/models/log.go index c2eeaeaad7f17..1dc5cea41f94c 100644 --- a/models/log.go +++ b/models/log.go @@ -7,7 +7,8 @@ package models import ( "fmt" - "code.gitea.io/log" + "code.gitea.io/gitea/modules/log" + "github.com/go-xorm/core" ) @@ -17,8 +18,8 @@ type XORMLogBridge struct { level core.LogLevel } -// NeXORMLogger inits a log bridge for xorm -func NeXORMLogger(showSQL bool) core.ILogger { +// NewXORMLogger inits a log bridge for xorm +func NewXORMLogger(showSQL bool) core.ILogger { return &XORMLogBridge{ showSQL: showSQL, } diff --git a/models/models.go b/models/models.go index 15134fecf1701..c7e58737ede83 100644 --- a/models/models.go +++ b/models/models.go @@ -260,7 +260,7 @@ func NewTestEngine(x *xorm.Engine) (err error) { } x.SetMapper(core.GonicMapper{}) - x.SetLogger(NeXORMLogger(!setting.ProdMode)) + x.SetLogger(NewXORMLogger(!setting.ProdMode)) x.ShowSQL(!setting.ProdMode) return x.StoreEngine("InnoDB").Sync2(tables...) } @@ -275,7 +275,7 @@ func SetEngine() (err error) { x.SetMapper(core.GonicMapper{}) // WARNING: for serv command, MUST remove the output to os.stdout, // so use log file to instead print to stdout. - x.SetLogger(NeXORMLogger(setting.LogSQL)) + x.SetLogger(NewXORMLogger(setting.LogSQL)) x.ShowSQL(setting.LogSQL) return nil } From 4b1191b653608102f215bec035f0d838c08836bb Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 14 May 2019 14:12:06 +0800 Subject: [PATCH 3/3] save logger on xorm log bridge --- models/log.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/models/log.go b/models/log.go index 1dc5cea41f94c..4994545c5f429 100644 --- a/models/log.go +++ b/models/log.go @@ -16,23 +16,20 @@ import ( type XORMLogBridge struct { showSQL bool level core.LogLevel + logger *log.Logger } // NewXORMLogger inits a log bridge for xorm func NewXORMLogger(showSQL bool) core.ILogger { return &XORMLogBridge{ showSQL: showSQL, + logger: log.GetLogger("xorm"), } } -// GetGiteaLevel returns the minimum Gitea logger level -func (l *XORMLogBridge) GetGiteaLevel() log.Level { - return log.GetLogger("xorm").GetLevel() -} - // Log a message with defined skip and at logging level func (l *XORMLogBridge) Log(skip int, level log.Level, format string, v ...interface{}) error { - return log.GetLogger("xorm").Log(skip+1, level, format, v...) + return l.logger.Log(skip+1, level, format, v...) } // Debug show debug log @@ -77,7 +74,7 @@ func (l *XORMLogBridge) Warnf(format string, v ...interface{}) { // Level get logger level func (l *XORMLogBridge) Level() core.LogLevel { - switch l.GetGiteaLevel() { + switch l.logger.GetLevel() { case log.TRACE, log.DEBUG: return core.LOG_DEBUG case log.INFO: