From cc7ba8a0b42c15a31e3ba69277ea46daff8ef742 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 6 Aug 2019 14:32:11 +0800 Subject: [PATCH] fix rename failed when rewrite public keys (#7761) --- models/ssh_key.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/models/ssh_key.go b/models/ssh_key.go index ceb4d9756075e..79e936fdcc9e7 100644 --- a/models/ssh_key.go +++ b/models/ssh_key.go @@ -642,12 +642,14 @@ func rewriteAllPublicKeys(e Engine) error { } _, err = t.WriteString(line + "\n") if err != nil { + f.Close() return err } } - defer f.Close() + f.Close() } + t.Close() return os.Rename(tmpPath, fPath) }