From e4b0212571def73450cf55a611d7e1559380a4d4 Mon Sep 17 00:00:00 2001 From: Guillermo Prandi Date: Fri, 8 Nov 2019 19:33:20 -0300 Subject: [PATCH 1/2] Fix registration password complexity --- routers/user/auth.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/routers/user/auth.go b/routers/user/auth.go index 82a508e4dc84f..b328ac094efab 100644 --- a/routers/user/auth.go +++ b/routers/user/auth.go @@ -1070,6 +1070,11 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo ctx.RenderWithErr(ctx.Tr("auth.password_too_short", setting.MinPasswordLength), tplSignUp, &form) return } + if !password.IsComplexEnough(form.Password) { + ctx.Data["Err_Password"] = true + ctx.RenderWithErr(ctx.Tr("form.password_complexity"), tplSignUp, &form) + return + } u := &models.User{ Name: form.UserName, From 4ffe9ba809aa6f27a495534f0e42d47d3c5a8509 Mon Sep 17 00:00:00 2001 From: Guillermo Prandi Date: Fri, 8 Nov 2019 22:12:12 -0300 Subject: [PATCH 2/2] Fix integration to use a complex password ;) --- integrations/signup_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/integrations/signup_test.go b/integrations/signup_test.go index 325c906326bf0..e122efa39c5b2 100644 --- a/integrations/signup_test.go +++ b/integrations/signup_test.go @@ -19,8 +19,8 @@ func TestSignup(t *testing.T) { req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{ "user_name": "exampleUser", "email": "exampleUser@example.com", - "password": "examplePassword", - "retype": "examplePassword", + "password": "examplePassword!1", + "retype": "examplePassword!1", }) MakeRequest(t, req, http.StatusFound)