Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed usage of deprecated io/ioutil package #1293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed usage of deprecated io/ioutil package #1293

wants to merge 1 commit into from

Conversation

amidam
Copy link
Contributor

@amidam amidam commented May 14, 2024

No description provided.

@amidam
Copy link
Contributor Author

amidam commented May 14, 2024

fixes #1292

@peterbourgon
Copy link
Member

Guess we should bump CI to drop 1.17, and probably also add 1.20, 1.21, and 1.22.

@peterbourgon
Copy link
Member

@amidam Please make those changes in this PR :)

@amidam
Copy link
Contributor Author

amidam commented May 18, 2024

@amidam Please make those changes in this PR :)

Sure

@amidam amidam force-pushed the fix/remove-ioutil branch from 40311af to a25864d Compare May 20, 2024 06:46
@amidam amidam force-pushed the fix/remove-ioutil branch from a25864d to 2bea8b4 Compare May 20, 2024 06:47
@amidam
Copy link
Contributor Author

amidam commented May 20, 2024

@peterbourgon, may I revise Go version in go.mod as well? Currently is 1.17

@peterbourgon
Copy link
Member

Should not be necessary, but if you want to update, I guess fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amidam @peterbourgon @melekes