Deterministically Expansion #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magodo an interesting test to conduct (manually) is to run the full test suite of go swagger with this commit replacing the go-openapi/spec package in go.mod. This test suite contains a lot of real life specs with many different patterns for $ref's and circular $ref's. In addition, some of these specs are quite large: this will be a good yardstick to figure out if your performance trade-off is viable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of the #79, where it introduces the non-deterministic expansion.
The test case for issue 957 is disabled in this PR as it is quite slow, though it is slow, it will still end ultimately.
Fix #93