Broken under Go 1.12 (relocation target runtime.acquirem not defined for ABI0 (but is defined for ABIInternal))

[neclepsio]

Compiling using Go 1.12 gives the following error:

cdata.Ref: relocation target runtime.acquirem not defined for ABI0 (but is defined for ABIInternal)
cdata.Ref: relocation target runtime.releasem not defined for ABI0 (but is defined for ABIInternal)

[neclepsio]

It should be related to https://github.com/golang/proposal/blob/master/design/27539-internal-abi.md#compatibility.

[neclepsio]

I was able to make it work removing the Refs function from assembly and adding this definition in a Windows-only file:

package cdata

import (
	"golang.org/x/sys/windows"
)

func Ref() uintptr {
	return uintptr(windows.GetCurrentThreadId())
}

Maybe this leaks a pointer so it shoud be modified to return a uint32, along with guiMainRef and guiPaintRef in bridge.go (and fixing related compilation errors). I suppose Linux and MacOS can use a similar approach using syscall.Gettid.

[nanu-c]

Your solution is only working in windows?

[neclepsio]

In neclepsio/qml-go there is a fix tested under Windows and Linux.

[nanu-c]

Thanks a lot, i merged your changes in my fork and i still had to rename the assembler files to get it working :)