Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds 922/account dashboard backend #1111

Open
wants to merge 2 commits into
base: BEDS-526/fix-internal-tx
Choose a base branch
from

Conversation

Tangui-Bitfly
Copy link
Contributor

@Tangui-Bitfly Tangui-Bitfly commented Nov 8, 2024

  • add data store in db2 to read from the data bigtable
  • only support tx and transfer for now
  • change keys to serve the future account dashboard
  • change keys format for better filter building
  • in key creation: use strings.Replace rather than fmt.Sprintf for better readability (and perf but that's not the main goal)
  • create Indexer struct, it's in a very WIP state
  • first e2e "unit" test in internal/e2e that test tx and transfer indexing and data retrieval

The focus of the review should be on package db2/data.
The first commit is a temp version using the current indexes to serve the account dashboard but it was subject to limitation, so don't spend much time reviewing unless you want to understand better the issues I faced.

Base automatically changed from BEDS-904/simulated to BEDS-526/fix-internal-tx November 15, 2024 12:52
@Tangui-Bitfly Tangui-Bitfly force-pushed the BEDS-526/fix-internal-tx branch 2 times, most recently from da0ce9c to d18c11a Compare November 20, 2024 15:05
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: f501998
Status: ✅  Deploy successful!
Preview URL: https://2c1455be.beaconchain.pages.dev
Branch Preview URL: https://beds-922-account-dashboard.beaconchain.pages.dev

View logs

db2/data: add method and time range filters
db2/data: ERC20 keys and add func
db2/data: working filters + data.Get
cmd/store: very basic remote store cmd
db2/data: use common.Address when possible
database/remote: implem more Database func
cmd/store: read column family
db/data: rework filter + add ByAsset
db2/data: external test
db2/data: fix filter + add unit tests for edge cases
db2/data: key use strings.Replace for clarity rather than Sprintf
db2/database: add tests + clean
@Tangui-Bitfly Tangui-Bitfly force-pushed the BEDS-922/account-dashboard branch 2 times, most recently from 85fdd90 to 41d0e9d Compare November 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant