Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Packr files shouldn't be created if no box is used #134

Closed
stanislas-m opened this issue Dec 22, 2018 · 0 comments
Closed

Packr files shouldn't be created if no box is used #134

stanislas-m opened this issue Dec 22, 2018 · 0 comments
Assignees
@markbates
Labels
enhancement New feature or request

Comments

@stanislas-m
Copy link
Member

Buffalo ecosystem uses gobuffalo/release tool to release its packages. The release tool always run packr, even if it's not needed by the project: this results in packr files generated with an empty filesystem.

See https://github.com/gobuffalo/fizz/blob/e70bf7d38ac1298601cccc46567ef323a12f8e51/packrd/packed-packr.go for an example.

Expected Behaviour

Packr doesn't generate its files if the user sources doesn't need them (i.e. no box usage in the user sources).
@markbates markbates added the enhancement New feature or request label Feb 6, 2019
@markbates markbates self-assigned this Feb 6, 2019
markbates added a commit that referenced this issue Feb 7, 2019
@markbates
Merge pull request #156 from gobuffalo/no-files-for-no-boxes
719d7cc 
Packr files shouldn't be created if no box is used fixes #134
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markbates markbates

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markbates @stanislas-m