Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Fix and add tests for box paths relative to an imported package #127

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Fix and add tests for box paths relative to an imported package #127

merged 3 commits into from
Jan 2, 2019

Conversation

bitspill
Copy link
Contributor

@bitspill bitspill commented Dec 7, 2018

No description provided.

markbates
markbates suggested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the files to not use mixed case? Go style is to use v2/_fixtures/import_pkg/pkg_test

@bitspill
Copy link
Contributor Author

Done.

Travis doesn't appear to have triggered again though, does it not respond to force-push?

@bitspill bitspill closed this Dec 11, 2018
@bitspill bitspill reopened this Dec 11, 2018
@bitspill
Copy link
Contributor Author

bitspill commented Dec 12, 2018 •
edited
Loading

Trying again since it's been several hours, from what I'd seen if GitHub doesn't send the notification close/reopen can trigger a build.

If it doesn't trigger might have to start a new one instead.

Edit: Ahaha, it worked. Travis build in progress finally.

@bitspill bitspill closed this Dec 12, 2018
@bitspill bitspill reopened this Dec 12, 2018
@bitspill bitspill mentioned this pull request Jan 1, 2019
Closed
@markbates markbates merged commit f9dae4b into gobuffalo:master Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markbates markbates markbates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitspill @markbates