Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new experimental link color theme support #541

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Jun 17, 2020

Trying the following experiment within Gutenberg 8.3+:

// Add support for experimental link colors.
add_theme_support( 'experimental-link-color' );

@cypress
Copy link

cypress bot commented Jun 17, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit 0896ebb
Started Aug 3, 2020 5:20 PM
Ended Aug 3, 2020 5:20 PM
Duration 00:50 💡
OS Linux Debian - 10.4
Browser Chrome 84

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor added [Priority] Low This issue/pull request is not immediate [Status] Do Not Merge Issues/PRs that should not be merged (yet) [Status] In Progress Tracking issues with work in progress [Type] Enhancement Something new that adds functionality labels Jun 26, 2020
@richtabor richtabor marked this pull request as draft June 26, 2020 18:22
@richtabor richtabor added this to the Next Release milestone Jul 27, 2020
@AnthonyLedesma
Copy link
Member

@richtabor Getting some strange behavior with the padding controls. Not sure this feature is ready to use yet.
experimentalControls

Color controls are working well!
experimentalControlsLinks

@richtabor
Copy link
Contributor Author

Currently there's no programmatic indicator of the padding controls (like there are for most other attributes), so our theme's default padding is overriding the functionality of the inline styles. I opened an issue on the Gutenberg repo WordPress/gutenberg#24337 to get one added; that way we can check for that class and contain our padding styles as the default/standard application (as it should be) and if a user applies a custom padding, it'll be 100% right.

@richtabor richtabor changed the title Try new experimental theme supports Add new experimental link color theme support Aug 3, 2020
@richtabor richtabor marked this pull request as ready for review August 3, 2020 17:19
@richtabor richtabor self-assigned this Aug 3, 2020
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly

@AnthonyLedesma AnthonyLedesma merged commit 3db1906 into master Aug 4, 2020
@AnthonyLedesma AnthonyLedesma deleted the try/experimental-theme-supports branch August 4, 2020 17:44
@EvanHerman EvanHerman removed [Status] Do Not Merge Issues/PRs that should not be merged (yet) [Status] In Progress Tracking issues with work in progress labels Aug 6, 2020
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.4 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants