Fixes layout, nodes and theming for Control Gallery Demo - 4.0 dev #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 tasks
aaronfranke
reviewed
Apr 3, 2022
gui/control_gallery/README.md
Outdated
| @@ -11,7 +11,7 @@ space between panels to resize them. | |||
|
|
|||
| Language: GDScript | |||
|
|
|||
| Renderer: GLES 2 | |||
| Renderer: Vulkan | |||
There was a problem hiding this comment.
If we're updating this text, we should be specifying if it's Vulkan Clustered or Vulkan Mobile.
Additionally, we should be setting demos to Vulkan Mobile if it doesn't look any different compared to Vulkan Clustered. Especially for GUI-only demos, they will look the same in Vulkan Mobile. Go to Project -> Project Settings -> General tab -> Rendering section -> Vulkan -> Back End -> Select Forward Mobile.
There was a problem hiding this comment.
Thanks for the info, I just changed the setting to Vulkan Mobile and made the change in the README.md file.
A lot of nodes have changed which made this demo not work properly anymore, nor display everything properly anymore. Everything is looking like it did before and all buttons are working again. There is however this slight bug in the engine right now which makes it not possible to press menu buttons or option buttons if the window is not the same as the content_scale_size of the main window. (By example when you resize the window) This is because the hitboxes for those buttons don't get notified of the change in screen size which makes them stay in the same place where they would be when resizing the window. For the rest everything is working perfectly now, everything also has the new Godot 4 default theme style. Fixes Control Gallery Demo for 4.0-dev small edit Forgot to center one of the labels + updated screenshot Changing Vulkan to Vulkan Mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of nodes have changed which made this demo not work properly
anymore, nor display everything properly anymore. Everything is looking
like it did before and all buttons are working again.
There is however this slight bug in the engine right now which makes it
not possible to press menu buttons or option buttons if the window is
not the same as the content_scale_size of the main window. (By example
when you resize the window)
This is because the hitboxes for those buttons don't get notified of the
change in screen size which makes them stay in the same place where they
would be when resizing the window.
For the rest everything is working perfectly now, everything also has
the new Godot 4 default theme style.
Ps.: I followed yesterday's advice to "squash" commits together. I've tried, not sure if it worked, if it didn't please let me know. ^^"