Improve 3D global illumination demo (4.0) #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
improve-global-illumination-demo
branch
2 times, most recently
from
28afe52 to
2a226f9
Compare
adamscott
approved these changes
Nov 25, 2022
|
I don't think the it's the demo's fault, but it kept happening on some GI modes. Capture.video.du.2022-11-24.20.34.31.webm |
Calinou
changed the title
Calinou
force-pushed
the
improve-global-illumination-demo
branch
from
2a226f9 to
a86cfa1
Compare
|
Rebased and tested again on 4.0.beta13, it works as expected. I also made an additional cosmetic change:
This is an engine issue, which I can reproduce on https://github.com/Calinou/godot-sponza's Edit: Issue opened: godotengine/godot#71585 |
- Readd LightmapGI example. - Allow toggling between the Once and Always update modes for the ReflectionProbe. - Add a Decal node to act as a blob shadow for dynamic objects. - Halve SSAO intensity for a better apperance in the demo's flat, bright surfaces. - Halve ambient light sky contribution when using the disabled or lightmap-based GI modes. This prevents the level's shaded areas from looking too bright and blue (with lightmaps, this change only affects dynamic objects.) - Enable FXAA and debanding for a better appearance.
Calinou
force-pushed
the
improve-global-illumination-demo
branch
from
a86cfa1 to
c22732e
Compare
akien-mga
approved these changes
Feb 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #718.