Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port demos with remade art assets to Godot 4 #922

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 23, 2023

This re-ports the following demos to Godot 4 following their latest 3.x versions:

  • 2D Navigation with AStarGrid2D
  • 2D JRPG Demo
  • 2D Isometric Game
  • 2D Platformer

Some tweaks have also been made in the process, such as split screen players having different colors in the 2D Platformer demo.

I'm having trouble porting the 2D JRPG demo due to AnimationTree stuff I'm not proficient with. Could someone lend a hand?
Edit: Fixed by Calinou#3. Thanks @Nonparoxysmic!

Preview

navigation_astar webp

isometric webp

platformer webp

@jtnicholl
Copy link
Contributor

The existing 4.0 version of the 2D platformer included cleaned up scripts, reorganized files, and improved controls. I'd prefer not to have that all be undone.

@Calinou
Copy link
Member Author

Calinou commented May 25, 2023

The existing 4.0 version of the 2D platformer included cleaned up scripts, reorganized files, and improved controls. I'd prefer not to have that all be undone.

I don't see an easy way to merge both. Redoing all the tiles and animations from scratch by basing myself on the 4.0 demo would be too much work.

I can try to replicate the new file structure and port some script changes from the 4.0 demo still.

Edit: Done.

@Calinou Calinou force-pushed the port-new-art-to-godot-4 branch from 9982db8 to 9f52b31 Compare May 25, 2023 23:28
@zf-moth
Copy link
Contributor

zf-moth commented Jun 27, 2023

I'm having trouble porting the 2D JRPG demo due to AnimationTree stuff I'm not proficient with. Could someone lend a hand?

@Calinou Do you still need help with that? Or is it finished?

@Calinou
Copy link
Member Author

Calinou commented Jun 28, 2023

@Calinou Do you still need help with that? Or is it finished?

I still need help with that, and won't have time to work on this in the near future. Please look into it if you can – it'll be very appreciated 🙂

Edit: See Calinou#3.

@Calinou
Copy link
Member Author

Calinou commented Oct 8, 2023

This should be good to merge thanks to @Nonparoxysmic's work 🙂

@Calinou Calinou force-pushed the port-new-art-to-godot-4 branch from 9c59c80 to 12005da Compare October 8, 2023 19:50
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval to unblock.

Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test with all four demos. Almost all of them work fine, there's just one thing: The dialog box in the RPG demo looks a bit weird/broken.

image

@Calinou
Copy link
Member Author

Calinou commented Feb 1, 2024

I've retested all demos on 4.2.1 and saved them again, with no warnings occurring when you run the projects.

I've fixed the JRPG demo UI theme (and have also increased font sizes to match the rest of the UI):

image

image

However, there's an issue with the navigation demo I get since 4.1. Nothing happens when I click on empty space on the TileMap, and I get this error:

ERROR: Can't get id path. Point (0, 0) out of bounds [P: (1, 1), S: (16, 8)].
   at: get_point_path (core/math/a_star_grid_2d.cpp:492)

Edit: I fixed the navigation AStar issue. It was caused by get_used_rect() not working anymore on TileMap, so I manually specified the size which is also more predictable in this demo.

@Calinou Calinou force-pushed the port-new-art-to-godot-4 branch 2 times, most recently from b05aed1 to ff8bd2d Compare February 1, 2024 19:38
This re-ports the following demos to Godot 4 following their latest `3.x` versions:

- 2D Navigation with AStarGrid2D
- 2D JRPG Demo
- 2D Isometric Game
- 2D Platformer

Some tweaks have also been made in the process, such as split screen players
having different colors in the 2D Platformer demo.

Co-authored-by: Nonparoxysmic <69494951+Nonparoxysmic@users.noreply.github.com>
@Calinou Calinou force-pushed the port-new-art-to-godot-4 branch from ff8bd2d to 7e73f79 Compare February 9, 2024 23:43
@smix8
Copy link
Contributor

smix8 commented Feb 10, 2024

Tested the 4 demos:

  • 2D Navigation with AStarGrid2D - works fine
  • 2D JRPG Demo (todo) - works with 4.2 but does not work with Godot master due to TileMapLayer changes.
  • 2D Isometric Game - works fine but has some weird "soft" shadow changes in the middle around where the carpet is placed.
  • 2D Platformer - works fine

Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demos work for 4.2.1 if that is the current target.

@Calinou Calinou merged commit 4d01a26 into godotengine:master Feb 10, 2024
1 check passed
@Calinou Calinou deleted the port-new-art-to-godot-4 branch February 10, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2d/role_playing_game broken on godot v4.0 name=GPUParticles2D type=CPUParticles2D
6 participants