-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port demos with remade art assets to Godot 4 #922
Conversation
The existing 4.0 version of the 2D platformer included cleaned up scripts, reorganized files, and improved controls. I'd prefer not to have that all be undone. |
I don't see an easy way to merge both. Redoing all the tiles and animations from scratch by basing myself on the 4.0 demo would be too much work. I can try to replicate the new file structure and port some script changes from the 4.0 demo still. Edit: Done. |
9982db8
to
9f52b31
Compare
@Calinou Do you still need help with that? Or is it finished? |
942c872
to
9c59c80
Compare
This should be good to merge thanks to @Nonparoxysmic's work 🙂 |
9c59c80
to
12005da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blind approval to unblock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've retested all demos on 4.2.1 and saved them again, with no warnings occurring when you run the projects. I've fixed the JRPG demo UI theme (and have also increased font sizes to match the rest of the UI):
Edit: I fixed the navigation AStar issue. It was caused by |
b05aed1
to
ff8bd2d
Compare
This re-ports the following demos to Godot 4 following their latest `3.x` versions: - 2D Navigation with AStarGrid2D - 2D JRPG Demo - 2D Isometric Game - 2D Platformer Some tweaks have also been made in the process, such as split screen players having different colors in the 2D Platformer demo. Co-authored-by: Nonparoxysmic <69494951+Nonparoxysmic@users.noreply.github.com>
ff8bd2d
to
7e73f79
Compare
Tested the 4 demos:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demos work for 4.2.1 if that is the current target.
This re-ports the following demos to Godot 4 following their latest
3.x
versions:Some tweaks have also been made in the process, such as split screen players having different colors in the 2D Platformer demo.
I'm having trouble porting the 2D JRPG demo due to AnimationTree stuff I'm not proficient with. Could someone lend a hand?Edit: Fixed by Calinou#3. Thanks @Nonparoxysmic!
and closes name=GPUParticles2D type=CPUParticles2D #785.
Preview