Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Physics Tests, fixed "one-way collision script error" #962

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Alex2782
Copy link
Contributor

v4.1.1.stable.official [bd6af8e0e]

The example is very complex, I am not sure if more changes are needed. (So far I have adjusted only one line)

image

"TEST OPTIONS":

  1. "Rigid body" -> "RESULT: PASSED"
  2. "Character body -> NOT PASSED"
Screen-2023-09-22-011239.mp4

@Calinou Calinou added the bug label Sep 21, 2023
@Alex2782
Copy link
Contributor Author

I could not find RigidDynamicBody2D in the version 3.0 documentation. I think node_name should rather be renamed to RigidBody2D.

image

@aaronfranke
Copy link
Member

@Alex2782 During Godot 4's development, RigidBody2D was renamed to RigidDynamicBody2D and then renamed again back to RigidBody2D, so yes you can replace RigidDynamicBody2D with RigidBody2D.

@Alex2782
Copy link
Contributor Author

@aaronfranke
The example for 'one-way collision' should be ready.

  • renamed to RigidBody2D
  • fixed Constrols / HSlider (could also still be incorrect in other examples)
  • fixed CharacterBody2D move_and_collide (docs: velocity vector multiplied by the frame timestep delta)

new size (Label = 120px, LabelValue = 60px)
image

For comparison, the size at 0px
image

tests: v4.1.1.stable.official [bd6af8e0e]

Screen-2023-09-23-031842.mp4

@Calinou Calinou requested a review from aaronfranke September 24, 2023 20:35
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go on my end.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 7e9d31b into godotengine:master Oct 18, 2023
1 check passed
@Alex2782 Alex2782 deleted the physics_tests_v4.1 branch October 18, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants