-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Mirroring Demo: ported to Godot 4.1 #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest checking what #930 does. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
If I close Godot and open the project again then everything is ok, Japanese is also displayed. |
I still can't get it to work on my end, even after removing PS: I noticed your PR adds two new files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fonts are clearly not ported correctly:
I would suggest doing something like this (from the clean state before any changes):
- Delete all font
*.tres
files (droid_sans.tres
,noto_font.tres
). - Reimport all font from the editor import tab (probably optional).
- Set fallbacks in the main font import settings and reimport it.
- Open the scene, and in the "Fix Dependencies" dialog, select the main font instead of missing font
*.tres
.
Also, do we need to ship all the font with the demos? For the Mirroring and Translation demos system font fallback should be fine, neither require specific font dimensions to work.
This comment was marked as outdated.
This comment was marked as outdated.
I had opened The file ' @smix8 says: #955 (comment)
@bruvzg does this PR work for you with binary 'res'-Fonts? Or is Japanese not displayed for you either?
I think there is little point in trying to fix problems I can't reproduce. |
There should not be any binary (or text) font resources at all, font files should be used directly. |
Something like this - bruvzg@0401f28 |
ok I'll check later, from some tutorials I know only first convert the fonts to "tres", also already with Godot 3.2 |
28b68b1
to
8159aeb
Compare
8159aeb
to
05e3444
Compare
now without 'fonts', this looks and works now like with 'fonts' (on MacOS) Should I remove |
I've tested that commit on 4.2.beta2 but I still can't see the CJK text (even after removing The UI mirroring demo update works well though. |
v4.2.dev5.official [e3e2528ba]
Screen-2023-10-06-012623.mp4