-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no header, non-TCP compliant msg for natives #229
Conversation
Can confirm, works for me. |
Is it possible to use text search in such documentation? In the previous versions text in documentation was not searchable too. |
You can search by class name, but not by the contents. We don't have access to the contents of the docs to search with. Godot sends a message containing its capabilities, which is a list of native classes and symbols, and the VSCode client stores them. When you ping the list, VSCode sends a message back to the language server asking it about a specific native symbol. Godot responds with the docs page. To make it searchable via text, we would need to either include a copy of the docs in the extension, or bombard the local server with a request for every native class and store them. -- EDIT: Unless you mean just being able to CTRL+F through one of the document you receive, in which case, maybe it's possible, I'll investigate. |
Yes, this is just what I mean. But this PR can be merged I think. |
Actually I just figured out it's very easy to do. I'll add it to the PR while it's open. |
910aa59
to
9ee66da
Compare
Add text-search widget to native symbol page Fixes godotengine#210
9ee66da
to
c5f1ba1
Compare
Thank you a lot, much more convenient now! |
Thanks |
The way messages are sent to the LSP server via TCP is slightly different between 3.1 websocket and 3.2 TCP/IP, requiring a header indicating the length of the message and a JSON object with a signature that requires a params: key that was lacking, and no ID.
Fixes #210
Also adds the Find widget to the native symbol pages that come up so you can CTRL+F through a page.