diff --git a/modules/openxr/extensions/openxr_fb_passthrough_extension_wrapper.cpp b/modules/openxr/extensions/openxr_fb_passthrough_extension_wrapper.cpp index f730f2bd2c31..3da0ffd9c731 100644 --- a/modules/openxr/extensions/openxr_fb_passthrough_extension_wrapper.cpp +++ b/modules/openxr/extensions/openxr_fb_passthrough_extension_wrapper.cpp @@ -71,7 +71,7 @@ Viewport *OpenXRFbPassthroughExtensionWrapper::get_main_viewport() { return nullptr; } - auto *scene_tree = Object::cast_to(main_loop); + SceneTree *scene_tree = Object::cast_to(main_loop); if (!scene_tree) { print_error("Unable to retrieve scene tree"); return nullptr; diff --git a/modules/openxr/openxr_api.cpp b/modules/openxr/openxr_api.cpp index 17f1c3940cfa..a66afee1c527 100644 --- a/modules/openxr/openxr_api.cpp +++ b/modules/openxr/openxr_api.cpp @@ -300,32 +300,31 @@ bool OpenXRAPI::create_instance() { for (OpenXRExtensionWrapper *wrapper : registered_extension_wrappers) { const HashMap &wrapper_request_extensions = wrapper->get_requested_extensions(); - // requested_extensions.insert(wrapper_request_extensions.begin(), wrapper_request_extensions.end()); - for (auto &requested_extension : wrapper_request_extensions) { + for (const KeyValue &requested_extension : wrapper_request_extensions) { requested_extensions[requested_extension.key] = requested_extension.value; } } - // Check which extensions are supported + // Check which extensions are supported. enabled_extensions.clear(); - for (auto &requested_extension : requested_extensions) { + for (KeyValue &requested_extension : requested_extensions) { if (!is_extension_supported(requested_extension.key)) { if (requested_extension.value == nullptr) { - // nullptr means this is a manditory extension so we fail + // Null means this is a manditory extension so we fail. ERR_FAIL_V_MSG(false, String("OpenXR: OpenXR Runtime does not support ") + requested_extension.key + String(" extension!")); } else { - // set this extension as not supported + // Set this extension as not supported. *requested_extension.value = false; } } else if (requested_extension.value != nullptr) { - // set this extension as supported + // Set this extension as supported. *requested_extension.value = true; - // and record that we want to enable it + // And record that we want to enable it. enabled_extensions.push_back(requested_extension.key.ascii()); } else { - // record that we want to enable this + // Record that we want to enable this. enabled_extensions.push_back(requested_extension.key.ascii()); } } @@ -2077,7 +2076,7 @@ XRPose::TrackingConfidence _transform_from_location(const T &p_location, Transfo Basis basis; Vector3 origin; XRPose::TrackingConfidence confidence = XRPose::XR_TRACKING_CONFIDENCE_NONE; - const auto &pose = p_location.pose; + const XrPosef &pose = p_location.pose; // Check orientation if (p_location.locationFlags & XR_SPACE_LOCATION_ORIENTATION_VALID_BIT) { diff --git a/modules/openxr/scene/openxr_hand.cpp b/modules/openxr/scene/openxr_hand.cpp index 91571a556de4..bedc8874d68b 100644 --- a/modules/openxr/scene/openxr_hand.cpp +++ b/modules/openxr/scene/openxr_hand.cpp @@ -213,8 +213,8 @@ void OpenXRHand::_update_skeleton() { quaternions[i] = Quaternion(); positions[i] = Vector3(); - const auto &location = hand_tracker->joint_locations[i]; - const auto &pose = location.pose; + const XrHandJointLocationEXT &location = hand_tracker->joint_locations[i]; + const XrPosef &pose = location.pose; if (location.locationFlags & XR_SPACE_LOCATION_ORIENTATION_VALID_BIT) { if (pose.orientation.x != 0 || pose.orientation.y != 0 || pose.orientation.z != 0 || pose.orientation.w != 0) { diff --git a/tests/core/variant/test_dictionary.h b/tests/core/variant/test_dictionary.h index 4571de64871c..5bc56075da1f 100644 --- a/tests/core/variant/test_dictionary.h +++ b/tests/core/variant/test_dictionary.h @@ -90,7 +90,7 @@ TEST_CASE("[Dictionary] Assignment using bracket notation ([])") { CHECK(int(map[false]) == 128); // Ensure read-only maps aren't modified by non-existing keys. - const auto length = map.size(); + const int length = map.size(); map.make_read_only(); CHECK(int(map["This key does not exist"].get_type()) == Variant::NIL); CHECK(map.size() == length); diff --git a/tests/scene/test_arraymesh.h b/tests/scene/test_arraymesh.h index 0e97e7d75f48..1623b413007e 100644 --- a/tests/scene/test_arraymesh.h +++ b/tests/scene/test_arraymesh.h @@ -195,7 +195,7 @@ TEST_CASE("[SceneTree][ArrayMesh] Surface metadata tests.") { } SUBCASE("Returns correct format for the mesh") { - auto format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX; + int format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX; CHECK((mesh->surface_get_format(0) & format) != 0); CHECK((mesh->surface_get_format(1) & format) != 0); } diff --git a/tests/servers/rendering/test_shader_preprocessor.h b/tests/servers/rendering/test_shader_preprocessor.h index d65eb522e8fa..c8c143641bc5 100644 --- a/tests/servers/rendering/test_shader_preprocessor.h +++ b/tests/servers/rendering/test_shader_preprocessor.h @@ -66,7 +66,7 @@ String remove_spaces(String &p_str) { for (int n = 0; n < p_str.size(); n++) { // These test cases only use ASCII. - auto c = static_cast(p_str[n]); + unsigned char c = static_cast(p_str[n]); if (std::isblank(c)) { has_removed = true; } else { @@ -92,7 +92,7 @@ String remove_spaces(String &p_str) { String compact_spaces(String &p_str) { Vector lines = p_str.split("\n", false); erase_all_empty(lines); - for (auto &line : lines) { + for (String &line : lines) { line = remove_spaces(line); } return String("\n").join(lines);