Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long error messages are displayed outside screen in console #15234

Closed
1 task done
mysticfall opened this issue Jan 1, 2018 · 5 comments · Fixed by #21884
Closed
1 task done

Long error messages are displayed outside screen in console #15234

mysticfall opened this issue Jan 1, 2018 · 5 comments · Fixed by #21884

Comments

@mysticfall
Copy link
Contributor

mysticfall commented Jan 1, 2018

Godot version:

Built from f11a138 with PR #15136.

OS/device including version:

Majaro Linux 17.1-rc2

Issue description:

When a long error message is logged to the console, it is impossible to read the whole content since the displayed tooltip is bigger than the screen size, as shown below:

godot-console

Ideally, console should show the detailed content in a separate view, when the user selects a message from the list. It is especially important when the message contains a stacktrace information.

Steps to reproduce:
Write a code that throws a runtime exception. I tried it with C# project, so I'm not too sure if the problem persists with a GDScript project.

  • I searched the existing GitHub issues for potential duplicates.
@RyanStein
Copy link
Contributor

RyanStein commented Jan 2, 2018

How does this look for a quick mock-up?

err_details_mockup

I used a VSplitContainer on the left and a read-only TextEdit for the details output, which shows the text normally found only in the tooltip. It allows selection for copying, as shown in the picture.

Alternatively, we could put the details split on the right side to give more height priority to the Error list, if the Stack Trace list doesn't require as much height.

@mysticfall
Copy link
Contributor Author

@RyanStein Looks fantastic to me :) I think it makes sense to put the stack trace pane to the right side, since stack information tends to grow vertically.

The only improvement I can think of is making details and stack trace panes collapsible, but it's a minor one and I'd be more than happy to see it implemented as it is.

@RyanStein
Copy link
Contributor

@mysticfall Thank you for the feedback. I've submitted the PR. The panes are not collapsible, though they are contained in SplitContainers, which allows them to be resized as needed, even very minimally so.

@mysticfall
Copy link
Contributor Author

Can't wait to try it out. Thanks much for the work! 😄

@akien-mga
Copy link
Member

akien-mga commented Aug 21, 2018

A cool PR was proposed to fix this in #15272, but couldn't be merged eventually due to merge conflicts and the PR getting stale. It's up for a rebase if any contributor is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants